New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transformations library #1717

Open
kain88-de opened this Issue Nov 24, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@kain88-de
Member

kain88-de commented Nov 24, 2017

https://www.lfd.uci.edu/~gohlke/code/transformations.py.html

There is a 2017 version of the library. Should we update it? I have also recently written the author about an odd behavior of the function quaternion_matrix which seems to return the matrix for the transpose quaternion.

@richardjgowers

This comment has been minimized.

Show comment
Hide comment
@richardjgowers

richardjgowers Nov 27, 2017

Member

#401 is related here.

I've never really been happy how we've included transformations, but it doesn't look like it's packaged up on pypi or conda. Is there a reason to "upgrade"? (if it isn't broke, don't fix it?)

Member

richardjgowers commented Nov 27, 2017

#401 is related here.

I've never really been happy how we've included transformations, but it doesn't look like it's packaged up on pypi or conda. Is there a reason to "upgrade"? (if it isn't broke, don't fix it?)

@kain88-de

This comment has been minimized.

Show comment
Hide comment
@kain88-de

kain88-de Nov 27, 2017

Member

I have to do a diff. It definitely looks different to our version though. The docs need definitely an update though. Some of the return values are surprising for example quaternion_matrix returns the transpose of the definition used in the reference given in transformations about quaternion matrix conversion.

Member

kain88-de commented Nov 27, 2017

I have to do a diff. It definitely looks different to our version though. The docs need definitely an update though. Some of the return values are surprising for example quaternion_matrix returns the transpose of the definition used in the reference given in transformations about quaternion matrix conversion.

@orbeckst

This comment has been minimized.

Show comment
Hide comment
@orbeckst

orbeckst Nov 27, 2017

Member

The proper way to do it would be a separate transformations package with its own tests. If Christoph Gohlke does not want to do this we could consider a fork in our repo and start maintaining it by pulling our tests into the separate lib.

Member

orbeckst commented Nov 27, 2017

The proper way to do it would be a separate transformations package with its own tests. If Christoph Gohlke does not want to do this we could consider a fork in our repo and start maintaining it by pulling our tests into the separate lib.

@orbeckst

This comment has been minimized.

Show comment
Hide comment
@orbeckst

orbeckst Dec 12, 2017

Member

A few people have created transformation packages but maintenance appears to be non-existent:

This one is maintained:

... but I don't think it includes the C versions of the transformations module.

Member

orbeckst commented Dec 12, 2017

A few people have created transformation packages but maintenance appears to be non-existent:

This one is maintained:

... but I don't think it includes the C versions of the transformations module.

@orbeckst orbeckst added the PBC label Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment