Port utils module to pytest #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kain88-de See this is what I was saying - I don't even understand how am I getting commits from you and Oliver. |
utkbansal
changed the title
utkbansal
force-pushed
the
squash
branch
2 times, most recently
from
b46c67d
to
15739d5
Compare
|
Woah, I squashed them into @richardjgowers's commit and it all disappeared. |
|
Haha, even quantified code is confused now 😆 |
Move utils module to run with pytest Get rid of staticmethods Fixed import ordering
|
Something very fishy here, those commits and diff disappeared into thin air. |
|
Can you detail the steps you followed? |
|
Sure
|
|
What I didn't understand was why was I seeing commits from Max & Oliver on doing And oddly there is a diff in the changelog!? |
richardjgowers
requested changes
Jun 24, 2017
.travis.yml
Outdated
| @@ -23,16 +23,16 @@ env: | |||
| - PYTHON_VERSION=2.7 | |||
| - COVERALLS=false | |||
| - NOSE_FLAGS="--processes=2 --process-timeout=400 --no-open-files --with-timer --timer-top-n 50" | |||
| - NOSE_TEST_LIST="analysis auxiliary core topology utils" | |||
| - NOSE_TEST_LIST="analysis auxiliary coordinates core topology" | |||
There was a problem hiding this comment.
this would revert the coordinates to use nose
utkbansal
force-pushed
the
squash
branch
3 times, most recently
from
7e447a7
to
d15869c
Compare
Converted test_units to use parametrize Some hacking of test_distances to use pytest features Completed moving test_distances to pytest style rewrote test_transformations into pytest style
Fix changelog
utkbansal
changed the title
|
This should be good to be merged now! |
richardjgowers
approved these changes
Jun 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths is a copy of PR 1419, have cleaned up the history here.
PR Checklist