New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest style: test_datafiles.py #1465

Merged
merged 2 commits into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@utkbansal
Member

utkbansal commented Jul 10, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@orbeckst orbeckst added the testing label Jul 11, 2017

@jbarnoud

Good to go except for a tiny comment.

import MDAnalysis.tests.datafiles
except ImportError:
raise AssertionError("Failed to 'import MDAnalysis.tests.datafiles --- install MDAnalysisTests")
def test_import():

This comment has been minimized.

@jbarnoud

jbarnoud Jul 11, 2017

Contributor

Look if @richardjgowers comment #1466 (review) applies.

@jbarnoud jbarnoud merged commit 7cb8500 into MDAnalysis:develop Jul 12, 2017

3 checks passed

QuantifiedCode No new issues introduced. 3 issue(s) fixed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 89.66%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment