Pytest Style: test_deprecated.py #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| import MDAnalysis.core.units | ||
| except ImportError: | ||
| raise AssertionError("MDAnalysis.core.units not available") |
There was a problem hiding this comment.
maybe we should use pytest.fail here?
|
Couldn't all of these test move to one parametrized function? Something in the lines of (from the top of my head, not even typed somewhere I could execute it): @pytest.mark.parametrize('module', (
'MDAnalysis.core.units',
'MDAnalysis.core.util',
'MDAnalysis.core.log',
...)
def test_import(module):
try:
importlib.import_module(module)
except ImportError:
raise AssertionError("{} not available".format(module)) |
4 tasks
kain88-de
requested changes
Jul 11, 2017
There was a problem hiding this comment.
Please address the requested changes from @richardjgowers and @jbarnoud
kain88-de
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #
Changes made in this Pull Request:
PR Checklist