Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPytest Style: test_selections.py #1471
Conversation
utkbansal
added some commits
Jul 10, 2017
orbeckst
added
the
testing
label
Jul 11, 2017
| class _SelectionWriter(TestCase): | ||
| __test__ = False | ||
| class _SelectionWriter(object): | ||
| # __test__ = False |
This comment has been minimized.
This comment has been minimized.
| @@ -189,7 +188,7 @@ def spt2array(line): | ||
| class TestSelectionWriter_Jmol(_SelectionWriter): | ||
| __test__ = True | ||
| # __test__ = True |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Wouldn't this test suite benefit from parametrizing the base class instead of subclassing it? |
| @@ -100,7 +99,6 @@ def lines2one(lines): | ||
| class TestSelectionWriter_Gromacs(_SelectionWriter): |
This comment has been minimized.
This comment has been minimized.
kain88-de
Jul 11, 2017
Member
why are you using the composition here? We wanted to Avoid mixing classes.
This comment has been minimized.
This comment has been minimized.
|
@jbarnoud @kain88-de |
This comment has been minimized.
This comment has been minimized.
|
Isn't this a case similar to the coordinates tests? |
This comment has been minimized.
This comment has been minimized.
|
Hum... They indeed differ more than I initially thought, especially the gromacs one. @kain88-de ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedJul 10, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist