Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPytest Style: test_imports.py #1473
Conversation
orbeckst
added
the
testing
label
Jul 11, 2017
| if self.is_excluded(fpath): | ||
| continue | ||
| yield self._run_test_relative_import, fpath | ||
| # yield self._run_test_relative_import, fpath |
This comment has been minimized.
This comment has been minimized.
| return paths | ||
| @pytest.mark.parametrize('testing_module', get_file_paths()) |
This comment has been minimized.
This comment has been minimized.
orbeckst
Jul 11, 2017
Member
looks like a sensible and pretty clean way to turn the yield-based test into a parametrized one, good!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| path_to_testing_modules = MDAnalysisTests.__path__[0] | ||
| # Exclusion path relative to MDAnalysisTests | ||
| exclusions = ['/plugins'] |
This comment has been minimized.
This comment has been minimized.
orbeckst
Jul 11, 2017
Member
Also add '/data' to exclusions – will save a tiny bit in the os.walk and makes clear that nothing in the data directory should be looked at. (There are no .py files in data so nothing changes overall anyway.)
This comment has been minimized.
This comment has been minimized.
|
@kain88-de @richardjgowers Review please. |
| path_to_testing_modules = MDAnalysisTests.__path__[0] | ||
| # Exclusion path relative to MDAnalysisTests | ||
| exclusions = ['/plugins', '/data'] |
This comment has been minimized.
This comment has been minimized.
jbarnoud
Jul 11, 2017
Contributor
Constants in the global scope should be in capital. PATH_TO_TESTING_MODULES and EXCLUSIONS. I'd like to see this changed but it is not blocking.
This comment has been minimized.
This comment has been minimized.
richardjgowers
Jul 12, 2017
Member
Yeah I'd have preferred this too, it makes it obvious where things have come from
| return paths | ||
| @pytest.mark.parametrize('testing_module', get_file_paths()) |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedJul 10, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist