New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest Style: topology/base.py #1526

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@utkbansal
Member

utkbansal commented Jul 19, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@richardjgowers

Looks good but there's lots of __test__ = True in all the files, can this get removed

@richardjgowers richardjgowers self-assigned this Jul 19, 2017

@utkbansal

This comment has been minimized.

Member

utkbansal commented Jul 19, 2017

@richardjgowers This only fixes the base.py files. All the other files will have their own PR. I had to edit other files to make them work with the fixture.

@utkbansal

This comment has been minimized.

Member

utkbansal commented Jul 20, 2017

@richardjgowers @kain88-de Do we really need to remove __test__ in this PR? I think it can be easily done in the file specific PRs. This PR only fixes base.py

@kain88-de

This comment has been minimized.

Member

kain88-de commented Jul 25, 2017

@richardjgowers please have a look at this. You have more experience with the topology system

@richardjgowers richardjgowers merged commit 1b8c667 into MDAnalysis:develop Jul 25, 2017

3 checks passed

QuantifiedCode 22 minor issues introduced.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.421%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment