Pytest Style: topology/base.py #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardjgowers
requested changes
Jul 19, 2017
Member
richardjgowers
left a comment
richardjgowers
left a comment
There was a problem hiding this comment.
Looks good but there's lots of __test__ = True in all the files, can this get removed
Member
Author
|
@richardjgowers This only fixes the base.py files. All the other files will have their own PR. I had to edit other files to make them work with the fixture. |
Member
Author
|
@richardjgowers @kain88-de Do we really need to remove |
Member
|
@richardjgowers please have a look at this. You have more experience with the topology system |
richardjgowers
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist