Pytest Style: core/test_atom.py #1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardjgowers
requested changes
Jul 20, 2017
| def test_attributes_positions(self, atom): | ||
| a = atom | ||
| # new position property (mutable) | ||
| assert_almost_equal(a.position, self.known_pos) |
Member
There was a problem hiding this comment.
known_pos is used once within the class, it can just live in this method
jbarnoud
requested changes
Jul 20, 2017
| def test_no_velo(self, atom): | ||
| def lookup_velo(): | ||
| return self.atom.velocity | ||
| return atom.velocity |
Contributor
There was a problem hiding this comment.
Since you are using the context manager to test the exception, you do not need the nested function.
| def test_bad_add(self, atom): | ||
| def bad_add(): | ||
| return self.atom + 1 | ||
| return atom + 1 |
Contributor
There was a problem hiding this comment.
You do not need the nested function here.
Member
Author
|
@jbarnoud @richardjgowers Good to go now? |
jbarnoud
approved these changes
Jul 22, 2017
Member
|
@utkbansal I've restarted the travis build. I'm curious why there is a drop of 0.03 percent in coverage. Maybe it goes away after rerunning the test but it would be nice if you could have a look into this. |
Member
Author
|
@kain88-de 0.01% Coveralls shows nothing. |
richardjgowers
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist