Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest Style analysis/test_gnm.py #1542

Merged
merged 3 commits into from Jul 30, 2017
Merged

Conversation

@utkbansal
Copy link
Member

@utkbansal utkbansal commented Jul 23, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@kain88-de
Copy link
Member

@kain88-de kain88-de commented Jul 26, 2017

can you remove the class

@utkbansal
Copy link
Member Author

@utkbansal utkbansal commented Jul 27, 2017

@kain88-de Better now?

@utkbansal utkbansal changed the title [WIP]Pytest Style analysis/test_gnm.py Pytest Style analysis/test_gnm.py Jul 27, 2017

result = gnm.results
assert len(result) == 10
time, eigenvalues, eigenvectors = zip(*result)

This comment has been minimized.

@kain88-de

kain88-de Jul 29, 2017
Member

I don't think you are importing the iterating zip at the top. from six.moves import zip Please fix that for py2/3 compatibility. It might break the test then you need to write list(zip(*result))

@kain88-de kain88-de merged commit 0cb6d08 into MDAnalysis:develop Jul 30, 2017
3 checks passed
3 checks passed
QuantifiedCode No new issues introduced. 8 issue(s) fixed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 90.419%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants