Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest Style analysis/test_gnm.py #1542

Merged
merged 3 commits into from Jul 30, 2017
Merged

Conversation

utkbansal
Copy link
Member

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@kain88-de
Copy link
Member

can you remove the class

@utkbansal
Copy link
Member Author

@kain88-de Better now?

@utkbansal utkbansal changed the title [WIP]Pytest Style analysis/test_gnm.py Pytest Style analysis/test_gnm.py Jul 27, 2017

result = gnm.results
assert len(result) == 10
time, eigenvalues, eigenvectors = zip(*result)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you are importing the iterating zip at the top. from six.moves import zip Please fix that for py2/3 compatibility. It might break the test then you need to write list(zip(*result))

@kain88-de kain88-de merged commit 0cb6d08 into MDAnalysis:develop Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants