[WIP]Pytest Style analysis/test_density.py

[utkbansal]

Fixes #

Changes made in this Pull Request:

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

[kain88-de]

build fails

[kain88-de]

build still fails

[utkbansal]

@kain88-de Can't figure what I broke in

def test_grid(self, D):
        dV = D.delta.prod()  # orthorhombic grids only!
        # counts = (rho[0] * dV[0] + rho[1] * dV[1] ...) = sum_i rho[i] * dV
        assert_almost_equal(D.grid.sum() * dV, self.counts)

[utkbansal]

@kain88-de Need help here.

[kain88-de]

@jbarnoud or @mnmelo could you have a look?

[jbarnoud]

On line 45, as you declare class attributes, you use the class attribute Lmax to build the other class attribute bins. When you do this, it seems that python tries to find Lmax in the parent scope rather than using the TestDensity.Lmax you just defined.

I think you need to create a fixture for bins. This fixture can have the class as scope.

[kain88-de]

Yes python doesn't allow using the attributes you declare in a list comprehension

[kain88-de]

please also remove the tempdir usage if you haven't done so already.