Pytest Style analysis/test_hbonds.py #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'angle': 150.0, | ||
| } | ||
|
|
||
| def _run(self, universe, **kwargs): |
There was a problem hiding this comment.
Shouldn't a method like this be replaced with a fixture? This would then make it easier to cache this result (if possible) by increasing the scope
There was a problem hiding this comment.
The kwargs are a problem to use a fixture here
There was a problem hiding this comment.
From what I can see it's only ever called as self._run(universe) so we could remove the kwargs?
richardjgowers
requested changes
Jul 25, 2017
richardjgowers
requested changes
Jul 26, 2017
| 'std': np.std, | ||
| } | ||
|
|
||
| def _normalize_timeseries(self, h): |
There was a problem hiding this comment.
Should just put this method into the fixture rather than refer to it
utkbansal
changed the title
|
@kain88-de @richardjgowers What needs to be done here? |
richardjgowers
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist