Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPytest Style analysis/test_hbonds.py #1544
Conversation
| 'angle': 150.0, | ||
| } | ||
| def _run(self, universe, **kwargs): |
This comment has been minimized.
This comment has been minimized.
richardjgowers
Jul 24, 2017
Member
Shouldn't a method like this be replaced with a fixture? This would then make it easier to cache this result (if possible) by increasing the scope
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
richardjgowers
Jul 25, 2017
Member
From what I can see it's only ever called as self._run(universe) so we could remove the kwargs?
richardjgowers
self-assigned this
Jul 25, 2017
richardjgowers
requested changes
Jul 25, 2017
Should replace _run with a fixture, and look to see if we can increase the scope of it
| 'std': np.std, | ||
| } | ||
| def _normalize_timeseries(self, h): |
This comment has been minimized.
This comment has been minimized.
richardjgowers
Jul 26, 2017
Member
Should just put this method into the fixture rather than refer to it
utkbansal
changed the title from
[WIP]Pytest Style analysis/test_hbonds.py
to
Pytest Style analysis/test_hbonds.py
Jul 29, 2017
This comment has been minimized.
This comment has been minimized.
|
@kain88-de @richardjgowers What needs to be done here? |
richardjgowers
merged commit b6a7cbc
into
MDAnalysis:develop
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedJul 23, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist