Pytest Style analysis/test_leaflet.py#1551
Merged
Merged
Conversation
kain88-de
reviewed
Jul 26, 2017
| lipid_head_string = "name PO4" | ||
|
|
||
| def test_leaflet_finder(self, universe, lipid_heads): | ||
| from MDAnalysis.analysis.leaflet import LeafletFinder |
Member
There was a problem hiding this comment.
import at the head of the file
| del self.universe | ||
| del self.lipid_heads | ||
| del self.lipid_head_string | ||
| class TestLeafletFinder(object): |
jbarnoud
requested changes
Jul 27, 2017
| @staticmethod | ||
| @pytest.fixture() | ||
| def universe(): | ||
| return MDAnalysis.Universe(Martini_membrane_gro, Martini_membrane_gro) |
Contributor
There was a problem hiding this comment.
This can be return MDAnalysis.Universe(Martini_membrane_gro)
| def lipid_heads(self, universe): | ||
| return universe.select_atoms("name PO4") | ||
|
|
||
| lipid_head_string = "name PO4" |
Contributor
There was a problem hiding this comment.
This should be defined at the beginning, and the variable name should be in capital if the class get removed. It should certainly not be defined in the class scope, in between two methods.
| def test_leaflet_finder(self): | ||
| @pytest.fixture() | ||
| def lipid_heads(self, universe): | ||
| return universe.select_atoms("name PO4") |
Contributor
There was a problem hiding this comment.
This could use the lipid_head_string variable.
Member
Author
|
@kain88-de @jbarnoud Better now? |
jbarnoud
approved these changes
Jul 27, 2017
utkbansal
changed the title
Member
Author
|
@kain88-de @jbarnoud Anything else to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist