Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest style analysis/test_persistencelength.py #1568

Merged

Conversation

utkbansal
Copy link
Member

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link
Contributor

@jbarnoud jbarnoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice to see the comments we made in the previous PR being already tackled in this one 👍

@utkbansal utkbansal changed the title [Review Needed]Pytest style analysis/test_persistencelength.py Pytest style analysis/test_persistencelength.py Jul 30, 2017
assert_almost_equal(p.lb, 1.485, 3)

def test_fit(self):
p = self._make_p()
def test_fit(self, p):
p.run()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have p run in the fixture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we can see to make the fixture module wide to save the initialization cost of the analyzsis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utkbansal This p_run fixture should use the p fixture. The p fixtureneeds to remain ortest_raise_NoDataError` will be broken.

@richardjgowers richardjgowers merged commit 8e3f0e1 into MDAnalysis:develop Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants