New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest style analysis/test_persistencelength.py #1568

Merged
merged 2 commits into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@utkbansal
Member

utkbansal commented Jul 30, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@jbarnoud

It is nice to see the comments we made in the previous PR being already tackled in this one 👍

@utkbansal utkbansal changed the title from [Review Needed]Pytest style analysis/test_persistencelength.py to Pytest style analysis/test_persistencelength.py Jul 30, 2017

assert_almost_equal(p.lb, 1.485, 3)
def test_fit(self):
p = self._make_p()
def test_fit(self, p):
p.run()

This comment has been minimized.

@kain88-de

kain88-de Jul 30, 2017

Member

please have p run in the fixture.

This comment has been minimized.

@kain88-de

kain88-de Jul 30, 2017

Member

Then we can see to make the fixture module wide to save the initialization cost of the analyzsis

This comment has been minimized.

@jbarnoud

jbarnoud Jul 30, 2017

Contributor

@utkbansal This p_run fixture should use the p fixture. The p fixtureneeds to remain ortest_raise_NoDataError` will be broken.

@richardjgowers richardjgowers merged commit 8e3f0e1 into MDAnalysis:develop Aug 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.419%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment