Pytest style analysis/test_persistencelength.py #1568
Merged
Conversation
|
It is nice to see the comments we made in the previous PR being already tackled in this one |
utkbansal
changed the title
| assert_almost_equal(p.lb, 1.485, 3) | ||
|
|
||
| def test_fit(self): | ||
| p = self._make_p() | ||
| def test_fit(self, p): | ||
| p.run() |
kain88-de
Jul 30, 2017
Member
please have p run in the fixture.
please have p run in the fixture.
kain88-de
Jul 30, 2017
Member
Then we can see to make the fixture module wide to save the initialization cost of the analyzsis
Then we can see to make the fixture module wide to save the initialization cost of the analyzsis
jbarnoud
Jul 30, 2017
Contributor
@utkbansal This p_run fixture should use the p fixture. The p fixtureneeds to remain ortest_raise_NoDataError` will be broken.
@utkbansal This p_run fixture should use the p fixture. The p fixtureneeds to remain ortest_raise_NoDataError` will be broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #
Changes made in this Pull Request:
PR Checklist