Pytest style analysis/test_persistencelength.py #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarnoud
approved these changes
Jul 30, 2017
Contributor
jbarnoud
left a comment
jbarnoud
left a comment
There was a problem hiding this comment.
It is nice to see the comments we made in the previous PR being already tackled in this one 👍
utkbansal
changed the title
kain88-de
requested changes
Jul 30, 2017
| def test_fit(self): | ||
| p = self._make_p() | ||
| def test_fit(self, p): | ||
| p.run() |
Member
There was a problem hiding this comment.
please have p run in the fixture.
Member
There was a problem hiding this comment.
Then we can see to make the fixture module wide to save the initialization cost of the analyzsis
Contributor
There was a problem hiding this comment.
@utkbansal This p_run fixture should use the p fixture. The p fixtureneeds to remain ortest_raise_NoDataError` will be broken.
kain88-de
approved these changes
Aug 1, 2017
richardjgowers
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist