Pytest Style analysis/test_psa.py #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkbansal
changed the title
jbarnoud
requested changes
Jul 30, 2017
| err_msg = "Dendrogram dictionary object was not produced" | ||
| assert_(type(self.plot_data[1]) is dict, err_msg) | ||
| assert type(plot_data[1]) is dict, err_msg |
There was a problem hiding this comment.
isinstance is probably more appropriate than type(...) is ....
| self.path_2) | ||
| self.expected = (np.mean(np.amin(self.distance_matrix, axis=0)) + | ||
| np.mean(np.amin(self.distance_matrix, axis = 1))) / 2. | ||
| # TODO: Fix this hack! without the fixture the test says I passed 3 |
There was a problem hiding this comment.
Could h be a class attribute rather than a fixture?
There was a problem hiding this comment.
I did try that, but when I make it a class attribute, the test fails saying that h expected 2 parameters but got 3.
There was a problem hiding this comment.
It looks indeed like h, when defined as a class attribute, is taken as a method. I guess you could define it as h = staticmethod(PSA.hausdorff_wavg) but I am not sure it is much better than the fixture. Maybe somebody will come with an idea. If not, we'll survive with the fixture.
jbarnoud
approved these changes
Jul 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist