Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPytest Style analysis/test_psa.py #1569
Conversation
utkbansal
added some commits
Jul 30, 2017
jbarnoud
added
the
needs review
label
Jul 30, 2017
utkbansal
changed the title from
[Review needed]Pytest Style analysis/test_psa.py
to
Pytest Style analysis/test_psa.py
Jul 30, 2017
| err_msg = "Dendrogram dictionary object was not produced" | ||
| assert_(type(self.plot_data[1]) is dict, err_msg) | ||
| assert type(plot_data[1]) is dict, err_msg |
This comment has been minimized.
This comment has been minimized.
| self.path_2) | ||
| self.expected = (np.mean(np.amin(self.distance_matrix, axis=0)) + | ||
| np.mean(np.amin(self.distance_matrix, axis = 1))) / 2. | ||
| # TODO: Fix this hack! without the fixture the test says I passed 3 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
utkbansal
Jul 30, 2017
Member
I did try that, but when I make it a class attribute, the test fails saying that h expected 2 parameters but got 3.
This comment has been minimized.
This comment has been minimized.
jbarnoud
Jul 30, 2017
Contributor
It looks indeed like h, when defined as a class attribute, is taken as a method. I guess you could define it as h = staticmethod(PSA.hausdorff_wavg) but I am not sure it is much better than the fixture. Maybe somebody will come with an idea. If not, we'll survive with the fixture.
jbarnoud
added this to the 0.17.0 milestone
Jul 30, 2017
jbarnoud
self-assigned this
Jul 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedJul 30, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist