Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPytest Style topology/test_gms.py #1588
Conversation
utkbansal
changed the title from
[Review Needed]Pytest Style topology/test_gms.py
to
Pytest Style topology/test_gms.py
Aug 5, 2017
| filename = GMS_ASYMOPT | ||
| expected_n_atoms = 6 | ||
| def test_names(self, top): | ||
| assert_array_equal(top.names.values, | ||
| assert_equal(top.names.values, |
This comment has been minimized.
This comment has been minimized.
| ['O', 'H', 'H', 'O', 'H', 'H']) | ||
| def test_types(self, top): | ||
| assert_array_equal(top.atomiccharges.values, | ||
| assert_equal(top.atomiccharges.values, |
This comment has been minimized.
This comment has been minimized.
| filename = GMS_SYMOPT | ||
| expected_n_atoms = 4 | ||
| def test_names(self, top): | ||
| assert_array_equal(top.names.values, | ||
| assert_equal(top.names.values, |
This comment has been minimized.
This comment has been minimized.
| ['CARBON', 'CARBON', 'HYDROGEN', 'HYDROGEN']) | ||
| def test_types(self, top): | ||
| assert_array_equal(top.atomiccharges.values, | ||
| assert_equal(top.atomiccharges.values, |
This comment has been minimized.
This comment has been minimized.
jbarnoud
merged commit 833d83a
into
MDAnalysis:develop
Aug 5, 2017
jbarnoud
self-assigned this
Aug 5, 2017
jbarnoud
added this to the 0.17.0 milestone
Aug 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 5, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist