Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest Style topology/test_gms.py #1588

Merged
merged 2 commits into from Aug 5, 2017
Merged

Conversation

@utkbansal
Copy link
Member

@utkbansal utkbansal commented Aug 5, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@utkbansal utkbansal changed the title [Review Needed]Pytest Style topology/test_gms.py Pytest Style topology/test_gms.py Aug 5, 2017
Copy link
Contributor

@jbarnoud jbarnoud left a comment

Small details to fix.

filename = GMS_ASYMOPT
expected_n_atoms = 6

def test_names(self, top):
assert_array_equal(top.names.values,
assert_equal(top.names.values,

This comment has been minimized.

@jbarnoud

jbarnoud Aug 5, 2017
Contributor

Next line should be align just after the parenthesis.

['O', 'H', 'H', 'O', 'H', 'H'])

def test_types(self, top):
assert_array_equal(top.atomiccharges.values,
assert_equal(top.atomiccharges.values,

This comment has been minimized.

@jbarnoud

jbarnoud Aug 5, 2017
Contributor

Fix alignment of the line bellow.

filename = GMS_SYMOPT
expected_n_atoms = 4

def test_names(self, top):
assert_array_equal(top.names.values,
assert_equal(top.names.values,

This comment has been minimized.

@jbarnoud

jbarnoud Aug 5, 2017
Contributor

Fix alignment bellow.

['CARBON', 'CARBON', 'HYDROGEN', 'HYDROGEN'])

def test_types(self, top):
assert_array_equal(top.atomiccharges.values,
assert_equal(top.atomiccharges.values,

This comment has been minimized.

@jbarnoud

jbarnoud Aug 5, 2017
Contributor

Fix alignment bellow.

@jbarnoud jbarnoud merged commit 833d83a into MDAnalysis:develop Aug 5, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.589%
Details
@jbarnoud jbarnoud self-assigned this Aug 5, 2017
@jbarnoud jbarnoud added this to the 0.17.0 milestone Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants