Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Review Needed]Pytest Style topology/test_gro.py #1590
Conversation
jbarnoud
requested changes
Aug 5, 2017
One more file about to bite the dust. A few things to fix, though.
| @@ -54,11 +48,11 @@ class TestGROParser(ParserBase): | ||
| def test_attr_size(self, top): | ||
| for attr in ['ids', 'names']: |
This comment has been minimized.
This comment has been minimized.
| resids = [1, 99999, 100000, 100001, 199999, 200000, 200001] | ||
| assert_(top.tt.size == (126, 7, 1)) | ||
| assert top.tt.size == (126, 7, 1) | ||
| for i, (r, n, l) in enumerate(zip(resids, self.names, self.lengths)): |
This comment has been minimized.
This comment has been minimized.
jbarnoud
Aug 5, 2017
Contributor
We probably can compare the full arrays rather than comparing element per element.
| def test_sameresid_diffresname(args): | ||
| i = args[0] | ||
| resid = args[1][0] | ||
| resname = args[1][1] |
This comment has been minimized.
This comment has been minimized.
| def test_sameresid_diffresname(): | ||
| @pytest.mark.parametrize( |
This comment has been minimized.
This comment has been minimized.
richardjgowers
Aug 5, 2017
Member
this doesn't really need to be parametrized, it all tests the same thing, rather than different cases of something
utkbansal
added some commits
Aug 8, 2017
jbarnoud
merged commit 69730f4
into
MDAnalysis:develop
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 5, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist