Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style topology/test_mol2.py #1597

Merged
merged 1 commit into from Aug 15, 2017

Conversation

utkbansal
Copy link
Member

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

jbarnoud
jbarnoud previously approved these changes Aug 8, 2017
'resids', 'resnames', 'bonds']
expected_attrs = [
'ids', 'names', 'types', 'charges', 'resids', 'resnames', 'bonds'
]
guessed_attrs = ['elements', 'masses']
expected_n_atoms = 49
expected_n_residues = 1
expected_n_segments = 1

def test_attr_size(self, top):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in an other PR, this could be updated to the base class.

@jbarnoud jbarnoud dismissed their stale review August 8, 2017 06:27

Clicked wrong button.

@jbarnoud jbarnoud merged commit 7b383c1 into MDAnalysis:develop Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants