New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style topology/test_mol2.py #1597

Merged
merged 1 commit into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@utkbansal
Member

utkbansal commented Aug 8, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
'resids', 'resnames', 'bonds']
expected_attrs = [
'ids', 'names', 'types', 'charges', 'resids', 'resnames', 'bonds'
]
guessed_attrs = ['elements', 'masses']
expected_n_atoms = 49
expected_n_residues = 1
expected_n_segments = 1
def test_attr_size(self, top):

This comment has been minimized.

@jbarnoud

jbarnoud Aug 8, 2017

Contributor

Same comment as in an other PR, this could be updated to the base class.

Clicked wrong button.

@jbarnoud jbarnoud merged commit 7b383c1 into MDAnalysis:develop Aug 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 90.589%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment