New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style topology/test_pqr.py #1600

Merged
merged 1 commit into from Aug 15, 2017

Conversation

Projects
None yet
3 participants
@utkbansal
Copy link
Member

utkbansal commented Aug 8, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
expected_attrs = [
'ids', 'names', 'charges', 'radii', 'resids', 'resnames', 'icodes',
'segids'
]
guessed_attrs = ['masses', 'types']
expected_n_atoms = 3341
expected_n_residues = 214
expected_n_segments = 1

def test_attr_size(self, top):

This comment has been minimized.

@jbarnoud

jbarnoud Aug 8, 2017

Contributor

This method could probably go in the base class and use the expected_attrs attribute.

This comment has been minimized.

@orbeckst

orbeckst Aug 14, 2017

Member

@jbarnoud would you be satisfied if these changes were implemented, i.e., can you upgrade your review from an informal comment to "changes requested" so that this can move along?

This comment has been minimized.

@jbarnoud

jbarnoud Aug 15, 2017

Contributor

It was just a general suggestion. But it may even be out of the scope of the PR.

@jbarnoud jbarnoud merged commit 4c465e9 into MDAnalysis:develop Aug 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.575%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment