New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 fixes topology/test_topology_str_types.py #1605

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
2 participants
@utkbansal
Member

utkbansal commented Aug 8, 2017

  • Replace hard tabs with spaces for indentation
  • Order imports

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
PEP8 fixes topology/test_topology_str_types.py
* Replace hard tabs with spaces for indentation
* Order imports

@utkbansal utkbansal changed the title from [Review Needed]PEP8 fixes topology/test_topology_str_types.py to PEP8 fixes topology/test_topology_str_types.py Aug 11, 2017

@utkbansal

This comment has been minimized.

Member

utkbansal commented Aug 11, 2017

@jbarnoud Merge?

@jbarnoud jbarnoud merged commit d98f063 into MDAnalysis:develop Aug 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 90.575%
Details
@utkbansal

This comment has been minimized.

Member

utkbansal commented Aug 11, 2017

@jbarnoud This is the sixth commit that doesn't show me as the author!

@jbarnoud

This comment has been minimized.

Contributor

jbarnoud commented Aug 11, 2017

@utkbansal Look at the history: I am only author of the merge commit, but your commit appears earlier at the time you actually committed it. That is how the "merge" button works, but I agree it is confusing.

@utkbansal

This comment has been minimized.

Member

utkbansal commented Aug 11, 2017

@jbarnoud Sorry for the false alarm. It was a bit confusing.

@jbarnoud

This comment has been minimized.

Contributor

jbarnoud commented Aug 11, 2017

@utkbansal Don't worry. It was a legitimate concern, and I did not realize what was happening right away either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment