Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPEP8 fixes topology/test_topology_str_types.py #1605
Conversation
utkbansal
changed the title from
[Review Needed]PEP8 fixes topology/test_topology_str_types.py
to
PEP8 fixes topology/test_topology_str_types.py
Aug 11, 2017
This comment has been minimized.
This comment has been minimized.
|
@jbarnoud Merge? |
jbarnoud
merged commit d98f063
into
MDAnalysis:develop
Aug 11, 2017
This comment has been minimized.
This comment has been minimized.
|
@jbarnoud This is the sixth commit that doesn't show me as the author! |
This comment has been minimized.
This comment has been minimized.
|
@utkbansal Look at the history: I am only author of the merge commit, but your commit appears earlier at the time you actually committed it. That is how the "merge" button works, but I agree it is confusing. |
This comment has been minimized.
This comment has been minimized.
|
@jbarnoud Sorry for the false alarm. It was a bit confusing. |
This comment has been minimized.
This comment has been minimized.
|
@utkbansal Don't worry. It was a legitimate concern, and I did not realize what was happening right away either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 8, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist