PEP8 fixes topology/test_topology_str_types.py #1605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace hard tabs with spaces for indentation * Order imports
jbarnoud
approved these changes
Aug 8, 2017
utkbansal
changed the title
Member
Author
|
@jbarnoud Merge? |
Member
Author
|
@jbarnoud This is the sixth commit that doesn't show me as the author! |
Contributor
|
@utkbansal Look at the history: I am only author of the merge commit, but your commit appears earlier at the time you actually committed it. That is how the "merge" button works, but I agree it is confusing. |
Member
Author
|
@jbarnoud Sorry for the false alarm. It was a bit confusing. |
Contributor
|
@utkbansal Don't worry. It was a legitimate concern, and I did not realize what was happening right away either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist