Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style topology/test_xyz.py #1608

Merged
merged 1 commit into from Aug 10, 2017

Conversation

@utkbansal
Copy link
Member

@utkbansal utkbansal commented Aug 8, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
Copy link
Contributor

@jbarnoud jbarnoud left a comment

Same comment as for test_tpr, could the children of XYZBase be generated somehow to avoid code duplication?

@jbarnoud jbarnoud merged commit ed17728 into MDAnalysis:develop Aug 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.589%
Details
@jbarnoud jbarnoud self-assigned this Aug 10, 2017
@jbarnoud jbarnoud added this to the 0.17.0 milestone Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants