Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review Needed]Pytest Style topology/test_xyz.py #1608

Merged
merged 1 commit into from
Aug 10, 2017
Merged

[Review Needed]Pytest Style topology/test_xyz.py #1608

merged 1 commit into from
Aug 10, 2017

Conversation

utkbansal
Copy link
Member

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

jbarnoud
jbarnoud reviewed Aug 8, 2017
View reviewed changes
Copy link
Contributor

@jbarnoud jbarnoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for test_tpr, could the children of XYZBase be generated somehow to avoid code duplication?

@jbarnoud jbarnoud merged commit ed17728 into MDAnalysis:develop Aug 10, 2017
@jbarnoud jbarnoud self-assigned this Aug 10, 2017
@jbarnoud jbarnoud added this to the 0.17.0 milestone Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbarnoud jbarnoud jbarnoud approved these changes

@richardjgowers richardjgowers richardjgowers approved these changes

Assignees

@jbarnoud jbarnoud

Labels
None yet
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@utkbansal @jbarnoud @richardjgowers