[Review Needed]Pytest Style analysis/test_hydrogenbondautocorrel.py#1611
Merged
richardjgowers merged 3 commits intoMDAnalysis:developfrom Aug 14, 2017
Merged
[Review Needed]Pytest Style analysis/test_hydrogenbondautocorrel.py#1611richardjgowers merged 3 commits intoMDAnalysis:developfrom
richardjgowers merged 3 commits intoMDAnalysis:developfrom
Conversation
richardjgowers
requested changes
Aug 8, 2017
| def O(self, u): | ||
| return u.atoms.select_atoms('name O') | ||
|
|
||
| # def setUp(self): |
jbarnoud
requested changes
Aug 11, 2017
| donors=N, | ||
| bond_type='continuous', | ||
| exclusions=self.excl_list, | ||
| exclusions=(np.array(range(len(H))), np.array( |
Contributor
There was a problem hiding this comment.
Use np.arange instead of np.array(range(...))
| return mda.Universe(TRZ_psf, TRZ) | ||
|
|
||
| @pytest.fixture() | ||
| def H(self, u): |
Contributor
There was a problem hiding this comment.
Could you rename this fixture hydrogens, please? Let's avoid abusing single letter variable names.
| return u.atoms.select_atoms('name Hn') | ||
|
|
||
| @pytest.fixture() | ||
| def N(self, u): |
| return u.atoms.select_atoms('name N') | ||
|
|
||
| @pytest.fixture() | ||
| def O(self, u): |
jbarnoud
approved these changes
Aug 11, 2017
richardjgowers
approved these changes
Aug 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist