New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style analysis/test_hydrogenbondautocorrel.py #1611

Merged
merged 3 commits into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@utkbansal
Copy link
Member

utkbansal commented Aug 8, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
def O(self, u):
return u.atoms.select_atoms('name O')

# def setUp(self):

This comment has been minimized.

@richardjgowers

@richardjgowers richardjgowers self-assigned this Aug 8, 2017

bond_type='continuous',
exclusions=self.excl_list,
exclusions=(np.array(range(len(H))), np.array(

This comment has been minimized.

@jbarnoud

jbarnoud Aug 11, 2017

Contributor

Use np.arange instead of np.array(range(...))

return mda.Universe(TRZ_psf, TRZ)

@pytest.fixture()
def H(self, u):

This comment has been minimized.

@jbarnoud

jbarnoud Aug 11, 2017

Contributor

Could you rename this fixture hydrogens, please? Let's avoid abusing single letter variable names.

return u.atoms.select_atoms('name Hn')

@pytest.fixture()
def N(self, u):

This comment has been minimized.

@jbarnoud

jbarnoud Aug 11, 2017

Contributor

nitrogens?

return u.atoms.select_atoms('name N')

@pytest.fixture()
def O(self, u):

This comment has been minimized.

@jbarnoud

jbarnoud Aug 11, 2017

Contributor

oxygens?

utkbansal added some commits Aug 11, 2017

@richardjgowers richardjgowers merged commit 09d168c into MDAnalysis:develop Aug 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.589%
Details

@orbeckst orbeckst referenced this pull request Aug 14, 2017

Merged

Docs disable travis button #1594

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment