Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style analysis/test_hydrogenbondautocorrel.py #1611

Merged
merged 3 commits into from Aug 14, 2017

Conversation

@utkbansal
Copy link
Member

@utkbansal utkbansal commented Aug 8, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
def O(self, u):
return u.atoms.select_atoms('name O')

# def setUp(self):
Copy link
Member

@richardjgowers richardjgowers Aug 8, 2017

del this

@richardjgowers richardjgowers self-assigned this Aug 8, 2017
bond_type='continuous',
exclusions=self.excl_list,
exclusions=(np.array(range(len(H))), np.array(
Copy link
Contributor

@jbarnoud jbarnoud Aug 11, 2017

Use np.arange instead of np.array(range(...))

return mda.Universe(TRZ_psf, TRZ)

@pytest.fixture()
def H(self, u):
Copy link
Contributor

@jbarnoud jbarnoud Aug 11, 2017

Could you rename this fixture hydrogens, please? Let's avoid abusing single letter variable names.

return u.atoms.select_atoms('name Hn')

@pytest.fixture()
def N(self, u):
Copy link
Contributor

@jbarnoud jbarnoud Aug 11, 2017

nitrogens?

return u.atoms.select_atoms('name N')

@pytest.fixture()
def O(self, u):
Copy link
Contributor

@jbarnoud jbarnoud Aug 11, 2017

oxygens?

@richardjgowers richardjgowers merged commit 09d168c into MDAnalysis:develop Aug 14, 2017
2 checks passed
@orbeckst orbeckst mentioned this pull request Aug 14, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants