Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Review Needed]Pytest Style core/test_updating_atomgroup.py #1619
Conversation
utkbansal
added some commits
Aug 15, 2017
utkbansal
changed the title from
[WIP]Pytest Style core/test_updating_atomgroup.py
to
[Review Needed]Pytest Style core/test_updating_atomgroup.py
Aug 15, 2017
| @pytest.fixture() | ||
| def ag_updating_compounded(self, u, ag): | ||
| return u.select_atoms("around 2 group sele", | ||
| sele=ag, updating=True) |
This comment has been minimized.
This comment has been minimized.
| def test_kwarg_check(self): | ||
| assert_equal(ag_updating_chained.indices, | ||
| ag_updating_compounded.indices) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Please fix all indentation issues. There are more to be found in the diff. I haven't marked them all. |
richardjgowers
assigned
kain88-de
Aug 15, 2017
This comment has been minimized.
This comment has been minimized.
|
@utkbansal please fix the indentations |
This comment has been minimized.
This comment has been minimized.
|
@kain88-de Is this good to go or is there something else to be done? |
kain88-de
merged commit b2ac888
into
MDAnalysis:develop
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 15, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist