New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style core/test_updating_atomgroup.py #1619

Merged
merged 5 commits into from Sep 4, 2017

Conversation

Projects
None yet
2 participants
@utkbansal
Member

utkbansal commented Aug 15, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

utkbansal added some commits Aug 15, 2017

@utkbansal utkbansal changed the title from [WIP]Pytest Style core/test_updating_atomgroup.py to [Review Needed]Pytest Style core/test_updating_atomgroup.py Aug 15, 2017

@kain88-de

looks good besides the indentaion

@pytest.fixture()
def ag_updating_compounded(self, u, ag):
return u.select_atoms("around 2 group sele",
sele=ag, updating=True)

This comment has been minimized.

@kain88-de

kain88-de Aug 15, 2017

Member

indentation

def test_kwarg_check(self):
assert_equal(ag_updating_chained.indices,
ag_updating_compounded.indices)

This comment has been minimized.

@kain88-de

kain88-de Aug 15, 2017

Member

indentaion

@kain88-de

This comment has been minimized.

Member

kain88-de commented Aug 15, 2017

Please fix all indentation issues. There are more to be found in the diff. I haven't marked them all.

@kain88-de

This comment has been minimized.

Member

kain88-de commented Aug 17, 2017

@utkbansal please fix the indentations

@utkbansal

This comment has been minimized.

Member

utkbansal commented Sep 1, 2017

@kain88-de Is this good to go or is there something else to be done?

use builtin next method
This is more future proof for a python3 only library in a couple of years.

@kain88-de kain88-de merged commit b2ac888 into MDAnalysis:develop Sep 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 90.583%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment