New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style core/test_topologyattrs.py #1620

Merged
merged 2 commits into from Aug 19, 2017

Conversation

Projects
None yet
2 participants
@utkbansal
Copy link
Member

utkbansal commented Aug 15, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
"""Mixin to test the common elements to all TopologyAttrs.
10 atoms
4 residues
2 segments
"""

__test__ = False

# Reference data
Ridx = np.array([0, 0, 2, 2, 1, 1, 3, 3, 1, 2])

This comment has been minimized.

@richardjgowers

richardjgowers Aug 15, 2017

Member

These don't need to live inside the class level, just put them in the fixture

@richardjgowers richardjgowers self-assigned this Aug 15, 2017

@richardjgowers richardjgowers merged commit 4a8f881 into MDAnalysis:develop Aug 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 90.603%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment