Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Review Needed]Pytest Stylecore/test_topology.py #1621
Conversation
utkbansal
added some commits
Aug 15, 2017
utkbansal
changed the title
[WIP]Pytest Stylecore/test_topology.py
[Review Needed]Pytest Stylecore/test_topology.py
Aug 15, 2017
richardjgowers
requested changes
Aug 15, 2017
| self.Sidx = np.array([0, 1, 1, 0]) | ||
| self.tt = TransTable(10, 4, 2, self.Ridx, self.Sidx) | ||
| class TestTransTable(object): | ||
| Ridx = np.array([0, 0, 2, 2, 1, 1, 3, 3, 1, 2]) |
This comment has been minimized.
This comment has been minimized.
richardjgowers
Aug 15, 2017
Member
these aren't used anywhere but the fixture, so can move these into there
richardjgowers
self-assigned this
Aug 15, 2017
richardjgowers
requested changes
Aug 21, 2017
| def test_move_residue_simple(self): | ||
| tt = self.tt | ||
| def test_move_residue_simple(self, tt): | ||
| tt = tt |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
richardjgowers
reviewed
Aug 22, 2017
| @@ -0,0 +1,14 @@ | |||
| import pytest | |||
This comment has been minimized.
This comment has been minimized.
richardjgowers
approved these changes
Aug 25, 2017
richardjgowers
merged commit 2364f13
into
MDAnalysis:develop
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 15, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist