Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Stylecore/test_topology.py #1621

Merged
merged 6 commits into from Aug 25, 2017

Conversation

@utkbansal
Copy link
Member

@utkbansal utkbansal commented Aug 15, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@utkbansal utkbansal changed the title [WIP]Pytest Stylecore/test_topology.py [Review Needed]Pytest Stylecore/test_topology.py Aug 15, 2017
self.Sidx = np.array([0, 1, 1, 0])
self.tt = TransTable(10, 4, 2, self.Ridx, self.Sidx)
class TestTransTable(object):
Ridx = np.array([0, 0, 2, 2, 1, 1, 3, 3, 1, 2])
Copy link
Member

@richardjgowers richardjgowers Aug 15, 2017

these aren't used anywhere but the fixture, so can move these into there

@richardjgowers richardjgowers self-assigned this Aug 15, 2017
def test_move_residue_simple(self):
tt = self.tt
def test_move_residue_simple(self, tt):
tt = tt
Copy link
Member

@richardjgowers richardjgowers Aug 21, 2017

I'm not sure this line is necessary

Copy link
Member

@orbeckst orbeckst Aug 21, 2017

Is this English politeness saying "It's not necessary, remove it"?

@@ -0,0 +1,14 @@
import pytest
Copy link
Member

@richardjgowers richardjgowers Aug 22, 2017

I guess this isn't meant to be here

@richardjgowers richardjgowers merged commit 2364f13 into MDAnalysis:develop Aug 25, 2017
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants