-
Notifications
You must be signed in to change notification settings - Fork 715
[Review Needed]Pytest Stylecore/test_topology.py #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
self.Sidx = np.array([0, 1, 1, 0]) | ||
self.tt = TransTable(10, 4, 2, self.Ridx, self.Sidx) | ||
class TestTransTable(object): | ||
Ridx = np.array([0, 0, 2, 2, 1, 1, 3, 3, 1, 2]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these aren't used anywhere but the fixture, so can move these into there
def test_move_residue_simple(self): | ||
tt = self.tt | ||
def test_move_residue_simple(self, tt): | ||
tt = tt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this line is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this English politeness saying "It's not necessary, remove it"?
@@ -0,0 +1,14 @@ | |||
import pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this isn't meant to be here
Fixes #
Changes made in this Pull Request:
PR Checklist