[Review Needed]Pytest Stylecore/test_topology.py #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkbansal
changed the title
richardjgowers
requested changes
Aug 15, 2017
| self.Sidx = np.array([0, 1, 1, 0]) | ||
| self.tt = TransTable(10, 4, 2, self.Ridx, self.Sidx) | ||
| class TestTransTable(object): | ||
| Ridx = np.array([0, 0, 2, 2, 1, 1, 3, 3, 1, 2]) |
There was a problem hiding this comment.
these aren't used anywhere but the fixture, so can move these into there
richardjgowers
requested changes
Aug 21, 2017
| def test_move_residue_simple(self): | ||
| tt = self.tt | ||
| def test_move_residue_simple(self, tt): | ||
| tt = tt |
There was a problem hiding this comment.
I'm not sure this line is necessary
There was a problem hiding this comment.
Is this English politeness saying "It's not necessary, remove it"?
| @@ -0,0 +1,14 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
I guess this isn't meant to be here
richardjgowers
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist