Pytest Style core/test_requires.py #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarnoud
approved these changes
Aug 15, 2017
kain88-de
reviewed
Aug 15, 2017
| assert 'frogs' in message | ||
| else: | ||
| raise AssertionError("Should raise NoDataError") | ||
| raise pytest.fail(msg="Should raise NoDataError") |
Member
There was a problem hiding this comment.
No, pytest.fail is a function and should just be called:
pytest.fail(msg="Should raise NoDataError")(See also real world examples).
utkbansal
changed the title
orbeckst
previously requested changes
Aug 16, 2017
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
See comment on pytest.fail().
| assert 'frogs' in message | ||
| else: | ||
| raise AssertionError("Should raise NoDataError") | ||
| raise pytest.fail(msg="Should raise NoDataError") |
Member
There was a problem hiding this comment.
Do not raise, just use imperatively:
else:
pytest.fail(msg="Should raise NoDataError")
Member
|
@utkbansal please address the issues |
richardjgowers
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist