Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Review Needed]Pytest Style core/test_atomselections.py #1634
Conversation
richardjgowers
self-assigned this
Aug 21, 2017
| class TestSelectionsCHARMM(TestCase): | ||
| def setUp(self): | ||
| class TestSelectionsCHARMM(object): | ||
| @pytest.fixture() |
This comment has been minimized.
This comment has been minimized.
richardjgowers
Aug 21, 2017
Member
can we increase the scope of this? You'll need to check if any test methods modify the universe in their test. If so, they'l need a function scoped version of the same Universe
This comment has been minimized.
This comment has been minimized.
utkbansal
Aug 21, 2017
Member
@richardjgowers Not sure what you meant by they'l need a function scoped version of the same Universe. Have pushed a commit, please have a look if this is what you meant.
This comment has been minimized.
This comment has been minimized.
richardjgowers
Aug 22, 2017
Member
If a test method modifies a class scoped fixture, the fixture will remain modified across all other test methods. So if we want to increase the scope of this fixture, we need to check to see if any methods will modify it. If any test methods do need to modify the fixture, they should use a different version of the fixture which is scoped to only the function.
utkbansal commentedAug 20, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist