[Review Needed]Pytest Style coordinates/test_gms.py #1639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kain88-de
requested changes
Aug 22, 2017
|
|
||
| @pytest.fixture() | ||
| def u(self): | ||
| return mda.Universe(GMS_SYMOPT) |
There was a problem hiding this comment.
it makes more sense to define this fixture in the base class and use a common class variable like self.trajectory_file to set it up instead of having to write the fixture for every child class. You already did that for other classes in coordinates.
There was a problem hiding this comment.
There was a problem hiding this comment.
These tests here are all in the same file. No need to use the request feature at this stage.
There was a problem hiding this comment.
Would it make sense to parametrize the base class in this case? We are not overriding any method here.
kain88-de
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist