New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style coordinates/test_gms.py #1639

Merged
merged 2 commits into from Aug 25, 2017

Conversation

Projects
None yet
3 participants
@utkbansal
Member

utkbansal commented Aug 21, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@pytest.fixture()
def u(self):
return mda.Universe(GMS_SYMOPT)

This comment has been minimized.

@kain88-de

kain88-de Aug 22, 2017

Member

it makes more sense to define this fixture in the base class and use a common class variable like self.trajectory_file to set it up instead of having to write the fixture for every child class. You already did that for other classes in coordinates.

This comment has been minimized.

This comment has been minimized.

@kain88-de

kain88-de Aug 23, 2017

Member

These tests here are all in the same file. No need to use the request feature at this stage.

This comment has been minimized.

@utkbansal

utkbansal Aug 24, 2017

Member

Would it make sense to parametrize the base class in this case? We are not overriding any method here.

@kain88-de kain88-de merged commit ef5dee9 into MDAnalysis:develop Aug 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.603%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment