Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Review Needed]Pytest Style coordinates/test_gms.py #1639
Conversation
| @pytest.fixture() | ||
| def u(self): | ||
| return mda.Universe(GMS_SYMOPT) |
This comment has been minimized.
This comment has been minimized.
kain88-de
Aug 22, 2017
Member
it makes more sense to define this fixture in the base class and use a common class variable like self.trajectory_file to set it up instead of having to write the fixture for every child class. You already did that for other classes in coordinates.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kain88-de
Aug 23, 2017
Member
These tests here are all in the same file. No need to use the request feature at this stage.
This comment has been minimized.
This comment has been minimized.
utkbansal
Aug 24, 2017
Member
Would it make sense to parametrize the base class in this case? We are not overriding any method here.
kain88-de
merged commit ef5dee9
into
MDAnalysis:develop
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 21, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist