Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Review Needed]Pytest Style coordinates/test_crd.py #1641
Conversation
kain88-de
approved these changes
Aug 22, 2017
richardjgowers
reviewed
Aug 22, 2017
| @@ -89,23 +82,23 @@ class TestCRDWriterMissingAttrs(object): | |||
| 'tempfactors': 0.0, | |||
| } | |||
|
|
|||
| def _check_warns(self, missing_attr): | |||
| @pytest.mark.parametrize('missing_attr', req_attrs) | |||
This comment has been minimized.
This comment has been minimized.
richardjgowers
Aug 22, 2017
Member
The tests are failing because parametrizing with a dict causes an unpredictable order for xdist
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
richardjgowers
Aug 24, 2017
Member
Yeah sure, that'd work too. Just something with a deterministic order, else "different" tests get collected by two processes.
orbeckst
self-assigned this
Aug 25, 2017
orbeckst
merged commit bf47a6a
into
MDAnalysis:develop
Aug 25, 2017
This comment has been minimized.
This comment has been minimized.
|
(The tests passed, just the one encore test flaked.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 21, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist