New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style coordinates/test_crd.py #1641

Merged
merged 2 commits into from Aug 25, 2017

Conversation

Projects
None yet
4 participants
@utkbansal
Copy link
Member

utkbansal commented Aug 21, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@@ -89,23 +82,23 @@ class TestCRDWriterMissingAttrs(object):
'tempfactors': 0.0,
}

def _check_warns(self, missing_attr):
@pytest.mark.parametrize('missing_attr', req_attrs)

This comment has been minimized.

@richardjgowers

richardjgowers Aug 22, 2017

Member

The tests are failing because parametrizing with a dict causes an unpredictable order for xdist

This comment has been minimized.

@orbeckst

orbeckst Aug 22, 2017

Member

Can you used a collections.OrderedDict?

This comment has been minimized.

@richardjgowers

richardjgowers Aug 24, 2017

Member

Yeah sure, that'd work too. Just something with a deterministic order, else "different" tests get collected by two processes.

@orbeckst orbeckst self-assigned this Aug 25, 2017

@orbeckst orbeckst merged commit bf47a6a into MDAnalysis:develop Aug 25, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-0.01%) to 90.589%
Details
@orbeckst

This comment has been minimized.

Copy link
Member

orbeckst commented Aug 25, 2017

(The tests passed, just the one encore test flaked.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment