[Review Needed]Pytest Style coordinates/test_crd.py #1641
Merged
Conversation
kain88-de
approved these changes
Aug 22, 2017
richardjgowers
reviewed
Aug 22, 2017
| @@ -89,23 +82,23 @@ class TestCRDWriterMissingAttrs(object): | |||
| 'tempfactors': 0.0, | |||
| } | |||
|
|
|||
| def _check_warns(self, missing_attr): | |||
| @pytest.mark.parametrize('missing_attr', req_attrs) | |||
The tests are failing because parametrizing with a dict causes an unpredictable order for xdist
Can you used a collections.OrderedDict?
Yeah sure, that'd work too. Just something with a deterministic order, else "different" tests get collected by two processes.
|
(The tests passed, just the one encore test flaked.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #
Changes made in this Pull Request:
PR Checklist
The text was updated successfully, but these errors were encountered: