Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style coordinates/test_crd.py #1641

Merged
merged 2 commits into from Aug 25, 2017

Conversation

@utkbansal
Copy link
Member

@utkbansal utkbansal commented Aug 21, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@@ -89,23 +82,23 @@ class TestCRDWriterMissingAttrs(object):
'tempfactors': 0.0,
}

def _check_warns(self, missing_attr):
@pytest.mark.parametrize('missing_attr', req_attrs)
Copy link
Member

@richardjgowers richardjgowers Aug 22, 2017

The tests are failing because parametrizing with a dict causes an unpredictable order for xdist

Copy link
Member

@orbeckst orbeckst Aug 22, 2017

Can you used a collections.OrderedDict?

Copy link
Member

@richardjgowers richardjgowers Aug 24, 2017

Yeah sure, that'd work too. Just something with a deterministic order, else "different" tests get collected by two processes.

@orbeckst orbeckst self-assigned this Aug 25, 2017
@orbeckst orbeckst merged commit bf47a6a into MDAnalysis:develop Aug 25, 2017
1 of 2 checks passed
@orbeckst
Copy link
Member

@orbeckst orbeckst commented Aug 25, 2017

(The tests passed, just the one encore test flaked.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants