[Review Needed]Pytest Style coordinates/test_lammps.py#1644
Merged
kain88-de merged 2 commits intoMDAnalysis:developfrom Aug 27, 2017
Merged
[Review Needed]Pytest Style coordinates/test_lammps.py#1644kain88-de merged 2 commits intoMDAnalysis:developfrom
kain88-de merged 2 commits intoMDAnalysis:developfrom
Conversation
kain88-de
requested changes
Aug 25, 2017
| def test_seek(self, u): | ||
| with pytest.raises(IndexError): | ||
| self.u.trajectory.__getitem__(1) | ||
| u.trajectory.__getitem__(1) |
| return mda.Universe(self.topology, self.trajectory, format=self.format) | ||
|
|
||
| def test_Writer_is_LAMMPS(self, u, tmpdir): | ||
| outfile = str(tmpdir) + 'lammps-writer-test' + \ |
Member
There was a problem hiding this comment.
outfile = os.path.join(str(tmpdir), 'lammps-writer-test' + ext)
Don't join paths manually!
Member
There was a problem hiding this comment.
In general those manual line breaks with \ are also not that nice and should be avoided if possible.
| assert W.flavor, self.flavor | ||
|
|
||
| def test_Writer(self, u, tmpdir, n_frames=3): | ||
| outfile = str(tmpdir) + 'lammps-writer-test' + \ |
| with self.u.trajectory.OtherWriter(self.outfile) as W: | ||
| assert_(W.flavor, self.flavor) | ||
| def test_OtherWriter_is_LAMMPS(self, u, tmpdir): | ||
| outfile = str(tmpdir) + 'lammps-writer-test' + \ |
| times = [] | ||
| with self.u.trajectory.OtherWriter(self.outfile) as w: | ||
| for ts in self.u.trajectory[::-1]: | ||
| outfile = str(tmpdir) + 'lammps-writer-test' + \ |
Member
Author
|
@kain88-de Anything else needed here? |
kain88-de
approved these changes
Aug 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist