New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style coordinates/test_netcdf.py & coordinates/test_trj.py #1647

Merged
merged 3 commits into from Aug 28, 2017

Conversation

Projects
None yet
2 participants
@utkbansal
Member

utkbansal commented Aug 25, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

utkbansal added some commits Aug 25, 2017

class _TRJReaderTest(TestCase):
__test__ = False
class _TRJReaderTest(object):
# use as a base class (override setUp()) and mixin a reference

This comment has been minimized.

@richardjgowers

richardjgowers Aug 25, 2017

Member

this comment isn't valid any more

@richardjgowers

fix outdated comment

@richardjgowers richardjgowers self-assigned this Aug 25, 2017

@utkbansal

This comment has been minimized.

Member

utkbansal commented Aug 26, 2017

@richardjgowers Should be good to go now.

@richardjgowers richardjgowers merged commit 141dc11 into MDAnalysis:develop Aug 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 90.589%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment