Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style coordinates/test_trj.py #1651

Merged
merged 2 commits into from Sep 4, 2017

Conversation

@utkbansal
Copy link
Member

@utkbansal utkbansal commented Aug 26, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
Copy link
Member

@orbeckst orbeckst left a comment

Travis fails with errors that look like an issue with the pytest re-write such as AttributeError: 'TestNCDFReader' object has no attribute 'topology_file' or E AttributeError: 'function' object has no attribute 'trajectory'.

Please fix.

@utkbansal
Copy link
Member Author

@utkbansal utkbansal commented Aug 30, 2017

The interesting part is that the tests are passing on my system.

@utkbansal
Copy link
Member Author

@utkbansal utkbansal commented Sep 1, 2017

It just needed a rebase. 😞

@kain88-de kain88-de dismissed orbeckst’s stale review Sep 4, 2017

not update from @orbeckst in the last 3 days.

@kain88-de kain88-de merged commit 363c94f into MDAnalysis:develop Sep 4, 2017
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants