New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style coordinates/test_trj.py #1651

Merged
merged 2 commits into from Sep 4, 2017

Conversation

Projects
None yet
3 participants
@utkbansal
Copy link
Member

utkbansal commented Aug 26, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@orbeckst
Copy link
Member

orbeckst left a comment

Travis fails with errors that look like an issue with the pytest re-write such as AttributeError: 'TestNCDFReader' object has no attribute 'topology_file' or E AttributeError: 'function' object has no attribute 'trajectory'.

Please fix.

@utkbansal

This comment has been minimized.

Copy link
Member

utkbansal commented Aug 30, 2017

The interesting part is that the tests are passing on my system.

utkbansal added some commits Aug 26, 2017

@utkbansal utkbansal force-pushed the utkbansal:coord-trj branch from 2972591 to 00d1701 Sep 1, 2017

@utkbansal

This comment has been minimized.

Copy link
Member

utkbansal commented Sep 1, 2017

It just needed a rebase. 😞

not update from @orbeckst in the last 3 days.

@kain88-de kain88-de merged commit 363c94f into MDAnalysis:develop Sep 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 90.603%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment