Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Review Needed]Pytest Style coordinates/test_trj.py #1651
Conversation
kain88-de
approved these changes
Aug 26, 2017
orbeckst
reviewed
Aug 28, 2017
|
Travis fails with errors that look like an issue with the pytest re-write such as Please fix. |
This comment has been minimized.
This comment has been minimized.
|
The interesting part is that the tests are passing on my system. |
utkbansal
added some commits
Aug 26, 2017
utkbansal
force-pushed the
utkbansal:coord-trj
branch
from
2972591
to
00d1701
Sep 1, 2017
This comment has been minimized.
This comment has been minimized.
|
It just needed a rebase. |
kain88-de
dismissed
orbeckst’s
stale review
Sep 4, 2017
not update from @orbeckst in the last 3 days.
kain88-de
merged commit 363c94f
into
MDAnalysis:develop
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
utkbansal commentedAug 26, 2017
Fixes #
Changes made in this Pull Request:
PR Checklist