Skip to content

[Review Needed]Pytest Style coordinates/test_trj.py #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2017

Conversation

utkbansal
Copy link
Member

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis fails with errors that look like an issue with the pytest re-write such as AttributeError: 'TestNCDFReader' object has no attribute 'topology_file' or E AttributeError: 'function' object has no attribute 'trajectory'.

Please fix.

@utkbansal
Copy link
Member Author

The interesting part is that the tests are passing on my system.

@utkbansal
Copy link
Member Author

It just needed a rebase. 😞

@kain88-de kain88-de dismissed orbeckst’s stale review September 4, 2017 20:23

not update from @orbeckst in the last 3 days.

@kain88-de kain88-de merged commit 363c94f into MDAnalysis:develop Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants