New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable mamba in CI #3177
Re-enable mamba in CI #3177
Conversation
The gains here are modest (~ minute and a half). Personally I think we should go ahead with it anyways, it adds up to ~ 10 mins of CPU time which is a non-insignificant environmental impact. |
Codecov Report
@@ Coverage Diff @@
## develop #3177 +/- ##
========================================
Coverage 92.81% 92.81%
========================================
Files 170 170
Lines 22801 22801
Branches 3239 3239
========================================
Hits 21162 21162
Misses 1591 1591
Partials 48 48 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
By the way, mdtraj has nuked conda/mamba for nix
. That could be something we could look at if installation remains slow.
https://github.com/mdtraj/mdtraj/blob/master/.github/workflows/main.yaml
Thanks @lilyminium I'm going to temporarily switch to draft though because I think my latest commit caused a performance regression.
Yeah, for now we should be fine, we're sub 1 minute for dependency installs on linux. Annoyingly MacOS takes much longer. |
nix looks interesting and is available for Linux and macOS. Is it a disadvantage to recommend, say, conda for users but use another package manager for the bulk of our testing? |
Alright, I think this is as optimised as I can get it. Main changes are:
Quick timing summary:Linux:full: ~ 2 mins less compared to current developminiconda setup: ~ 1 min min: ~ 1 min less compared to current developminiconda_setup: ~ 1 min build_docs: ~ 3 mins less compared to current developsetup_miniconda: ~ 1 min pylint: ~ same as current developsetup_miniconda: 46s pypi_check: same as current developsetup_miniconda: 32s macOS:full: for setup ~ 7 mins less compared to current developsetup_miniconda: 1m 9s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for commenting why it's a conda install in pypi_check.
Fixes #3048
Changes made in this Pull Request:
Testing on some cron jobs I'll push to MDA later, it looks like it works now (not sure if it's that stable, but I guess we can always disable again if it fails).
PR Checklist