Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the pyedr and panedr packages #50

Merged
merged 13 commits into from Jul 15, 2022
Merged

Create the pyedr and panedr packages #50

merged 13 commits into from Jul 15, 2022

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 14, 2022

Fixes #48

Changes

  • Creates new package pyedr and moves pandas specific code bits to panedr.
  • Also moves tests to be packaged so datafiles can be accessed from one package to the other.
  • Adds pyedr specific tests
  • Adds deploy yaml action
  • Fix readme file

@pep8speaks
Copy link

pep8speaks commented Jul 14, 2022

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:1: E402 module level import not at top of file

Line 1:1: E265 block comment should start with '# '

Line 1:1: E265 block comment should start with '# '
Line 45:45: E231 missing whitespace after ','
Line 74:80: E501 line too long (81 > 79 characters)

Line 7:1: E402 module level import not at top of file

Line 1:1: E265 block comment should start with '# '

Line 31:34: W291 trailing whitespace
Line 41:45: E231 missing whitespace after ','

Line 7:1: E124 closing bracket does not match visual indentation

Comment last updated at 2022-07-15 00:41:11 UTC

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #50 (91ef910) into master (9bad58e) will increase coverage by 6.05%.
The diff coverage is 99.29%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   83.15%   89.21%   +6.05%     
==========================================
  Files           2        7       +5     
  Lines         279      482     +203     
==========================================
+ Hits          232      430     +198     
- Misses         47       52       +5     
Impacted Files Coverage Δ
panedr/panedr/tests/test_edr.py 98.82% <98.82%> (ø)
panedr/panedr/__init__.py 100.00% <100.00%> (ø)
panedr/panedr/panedr.py 100.00% <100.00%> (ø)
pyedr/pyedr/__init__.py 100.00% <100.00%> (ø)
pyedr/pyedr/pyedr.py 82.33% <100.00%> (ø)
pyedr/pyedr/tests/datafiles.py 100.00% <100.00%> (ø)
pyedr/pyedr/tests/test_edr.py 96.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bad58e...91ef910. Read the comment docs.

Copy link
Collaborator

@jbarnoud jbarnoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbarnoud jbarnoud merged commit e278a84 into master Jul 15, 2022
@orbeckst orbeckst deleted the pyedr branch July 15, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panedrlite should allow import panedr
3 participants