-
Notifications
You must be signed in to change notification settings - Fork 121
Homebrew formula #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+49
−22
Merged
Homebrew formula #1039
Changes from all commits
Commits
Show all changes
150 commits
Select commit
Hold shift + click to select a range
b60f27c
feat: Add Homebrew and Spack package definitions
sbryngelson 007e05e
chore: Remove Spack files (Homebrew-only branch)
sbryngelson 95097c9
docs: Consolidate Homebrew documentation into single file
sbryngelson edfc8fe
chore: Remove non-Homebrew documentation files
sbryngelson c1b5453
chore: Remove README/CITATION changes and issue templates
sbryngelson e34711d
refactor: Move Homebrew files to packaging/homebrew/ directory
sbryngelson 6ee36b7
docs: Update README to match latest upstream version
sbryngelson 33e9645
docs: Update README and CITATION.cff, add issue templates (#1022)
sbryngelson 7d21ed3
fix: Address PR review feedback for Homebrew formula
sbryngelson 35b4469
refactor: Implement all PR review suggestions for Homebrew formula
sbryngelson bd9f51e
fix: Address Copilot PR review comments
sbryngelson dd0b8c4
fix up
sbryngelson 07ee05e
docs: Address final Copilot review suggestions
sbryngelson 29a928d
fix: Implement qodo-merge-pro safety improvements
sbryngelson d1d1c67
ci: Add Homebrew formula testing workflow
sbryngelson b2e034e
fix: Address all Homebrew style violations
sbryngelson 86a4c89
fix
sbryngelson 79924a4
fix?
sbryngelson b7c580c
fix
sbryngelson 919a800
Fix Homebrew CI: use local tap for formula installation
sbryngelson 9fd8391
Restore bug_report.md from master branch
sbryngelson d176487
Fix Homebrew formula: handle hashed installation directory
sbryngelson 5f5ced5
Fix: Find each binary individually in separate hashed directories
sbryngelson d372e63
Simplify Homebrew formula to install binaries only
sbryngelson 3c5d327
push
sbryngelson 161d41d
Fix test: Don't run binaries with -h flag
sbryngelson 52de223
Fix Homebrew style: Use assert_path_exists instead of assert_predicat…
sbryngelson 1d3bc21
Install full MFC toolchain with smart wrapper for read-only Cellar
sbryngelson 3b8c950
Fix formula test: Don't trigger Python venv setup
sbryngelson 46e325a
Add Cantera dependency and pre-install Python venv
sbryngelson a38350f
Build Cantera 3.1.0 from source instead of PyPI
sbryngelson 272340a
Complete Cantera 3.1.0 source build implementation
sbryngelson 9b8db76
Fix trailing whitespace errors in Homebrew formula
sbryngelson 5a48e36
Fix Cantera resource: remove incorrect revision hash
sbryngelson 5d7ef61
Fix unnecessary spacing in Cantera resource definition
sbryngelson b8a2940
Fix: Build Cantera before MFC to avoid PyPI dependency error
sbryngelson 9a45f65
Fix Homebrew style: Use ENV.fetch instead of ENV[]
sbryngelson 4e5cc79
Add packaging module to Cantera build dependencies
sbryngelson 1cd2cc3
Fix: Run scons via venv Python to find packaging module
sbryngelson 5d2eb66
Remove scons from Homebrew dependencies
sbryngelson e2c249c
Fix Cantera build: Pass compiler and SDK paths to scons
sbryngelson 4edc60f
Fix: Pass compiler flags as environment variables, not scons args
sbryngelson 55ca2b0
Fix hash alignment for Homebrew style check
sbryngelson f9d3409
Add verbose logging and artifacts to Homebrew CI
sbryngelson 24452d4
Fix brew test version check by committing formula to tap
sbryngelson 26df743
Fix: Modify ENV directly instead of passing hash to system
sbryngelson dd0ba7c
Replace brew test with direct test commands
sbryngelson 3a4ce68
Pass compiler flags directly to scons as build arguments
sbryngelson 301ea0b
Fix trailing whitespace on line 45
sbryngelson f3643b9
Fix test: use formula-specific prefix for libexec check
sbryngelson ef4aba5
Fix Cantera build: Set ENV vars and explicit compilers for scons
sbryngelson 7dc3c9a
Fix trailing whitespace on lines 44 and 51
sbryngelson 09fe44e
Fix TypeError: Set SDKROOT in ENV instead of passing hash to system
sbryngelson 19fe2d9
Add SDK C++ include path to scons extra_inc_dirs
sbryngelson b1c75bb
Pass compiler flags as scons variables for configure checks
sbryngelson 1612552
Fix RuboCop: Use ENV.fetch instead of ENV[] for compiler flags
sbryngelson 3973747
Fix Cantera scons: Use cc_flags/cxx_flags instead of CCFLAGS/CXXFLAGS
sbryngelson d4dcaaa
Add C++ include path directly to cxx_flags for scons checks
sbryngelson 23949ef
Add SDK main include path to compiler flags for C header access
sbryngelson 0385aa8
Add Cantera config.log capture to CI for debugging
sbryngelson 00f8295
Fix CI: Add pipefail to catch brew install failures
sbryngelson 7f34c7e
Add config.log output on Cantera build failure
sbryngelson abe825a
Fix RuboCop style: remove trailing whitespace and shorten long line
sbryngelson 4bffab5
Improve config.log capture: search recursively and list directory con…
sbryngelson bd376b4
Fix RuboCop: remove trailing whitespace on lines 87 and 99
sbryngelson f4fa72e
Enhance debug output: use opoo, check multiple config.log locations, …
sbryngelson b8c2463
Remove Cantera from formula - make it an optional user-installed depe…
sbryngelson 06edb9b
Install Cantera from PyPI instead of building from source
sbryngelson 9e21f25
Fix RuboCop: use assert_path_exists instead of assert_predicate with …
sbryngelson 5ee24d4
Fix mfc.sh build: ensure we're in buildpath directory
sbryngelson 62393d1
Add debug output to diagnose mfc.sh directory issue
sbryngelson 69427d9
Fix trailing whitespace in formula
sbryngelson b9d4148
Fix mfc.sh build: keep toolchain in buildpath during build
sbryngelson 96fe6d4
Fix mfc wrapper script: add toolchain symlink and build directory
sbryngelson 5c9bbb7
Fix Homebrew formula: copy directories instead of symlinking to avoid…
sbryngelson 9163b77
Fix Homebrew formula: ensure fresh venv on each install
sbryngelson ed9c328
Fix CI: handle Homebrew dylib fixup warnings gracefully
sbryngelson 0d472e7
Fix CI: remove invalid mfc count test
sbryngelson 5a7a31a
Fix CI: use absolute path for test case file
sbryngelson 8de2268
Remove 'mfc run' test from CI and clarify Homebrew limitations
sbryngelson bc7175f
Enable 'mfc run' by patching toolchain to use Homebrew binaries
sbryngelson c56cd92
Fix mfc run: patch toolchain to skip building and use Homebrew binaries
sbryngelson cae22fd
Fix wrapper script creation and permissions
sbryngelson 09c8bf2
Fix executable permissions with post_install hook
sbryngelson 385061a
Fix CI: use absolute path for case.py in mfc run test
sbryngelson 692519f
docs
sbryngelson 1408aec
docs
sbryngelson 5b85475
cleanup
sbryngelson ef66c9a
harden
sbryngelson d3b1a93
quick start
sbryngelson e75b7ff
deploy to repo
sbryngelson 415ad05
push
sbryngelson 8a75271
remove test
sbryngelson d1381c8
improve and deploy
sbryngelson 3efb9d6
ci(homebrew): merge duplicate push blocks in deploy-tap.yml
sbryngelson 845c68b
minor trigger
sbryngelson a7572e2
ci(homebrew): fix brew audit to use formula name instead of path
sbryngelson 2308b9a
bump to trigger
sbryngelson 3be3e15
fix(homebrew): use rm_r instead of rm_rf per brew audit
sbryngelson 1a32884
minor
sbryngelson 6b5bd9f
fix(homebrew): only install executable files to bin
sbryngelson 5da2c3a
style(homebrew): fix rubocop guard clause style
sbryngelson 8215624
fix(homebrew): move venv to var/ to avoid dylib fixups and harden bin…
sbryngelson 3ff41d1
style(homebrew): fix heredoc indentation for rubocop
sbryngelson 72304d5
fix(ci): update venv path check in homebrew.yml workflow
sbryngelson 43bfb7b
feat(ci): add smoke tests before expensive Homebrew installation
sbryngelson 1bb2226
minor
sbryngelson 315c4fd
fix(ci): configure git identity for brew tap-new in smoke tests
sbryngelson f7e6aea
fix(homebrew): correct Python indentation in build.py patch
sbryngelson 81e30ff
fix
sbryngelson bb096d7
trigger
sbryngelson efb6c53
try again deploy
sbryngelson 93f8c3b
fix
sbryngelson 2db4c31
fixup
sbryngelson 59f196b
add test
sbryngelson 0aab6ca
fix
sbryngelson 66e2093
fix?
sbryngelson 323e3bf
Fix homebrew.yml: Update venv path from var/mfc/venv to libexec/venv
sbryngelson 11a4e98
Fix lock.yaml write error by redirecting MFC paths to temp directory
sbryngelson c3b0c1d
Use sitecustomize.py for early MFC path patching
sbryngelson 95f2109
Fix Homebrew formula: disable bottles to avoid relocation errors
sbryngelson ede409c
Fix Homebrew formula to enable proper bottle creation
sbryngelson dcc6031
Fix Cantera build issue: use pre-built wheel for Cantera, compile MFC…
sbryngelson addcd87
Simplify MFC deps install: let pip choose wheels vs source builds
sbryngelson 25a39df
Fix orjson dylib relocation by forcing source compilation
sbryngelson 9d4e299
Use bottle :unneeded to skip bottling for Python venv
sbryngelson e3a7f3c
Remove deprecated 'bottle :unneeded' causing wrong-arity error in bre…
sbryngelson 2b2b749
Add Rust dependency and rebuild orjson with headerpad for bottle relo…
sbryngelson cf453b9
Move mfc wrapper to libexec and use write_exec_script for audit compl…
sbryngelson f5f9abb
Remove Rust dependency and orjson source rebuild - not needed with li…
sbryngelson b1e3ac5
Add skip_clean for libexec/venv to prevent orjson dylib relocation er…
sbryngelson c73b091
Improve Homebrew wrapper UX: add help, block unsupported commands, fi…
sbryngelson 9ade107
Add Homebrew installation and usage documentation
sbryngelson 6970bce
cleanup
sbryngelson 61adc7e
Add README for Homebrew tap and auto-deploy it
sbryngelson 1e78657
tap
sbryngelson cb29fc5
minor diff
sbryngelson 7c7543f
Add smart case file detection to mfc wrapper
sbryngelson 4041006
Merge upstream/master into homebrew-formula
sbryngelson 346c413
Fix RuboCop style error: remove redundant escape in regex
sbryngelson ec24979
Update CI to test shorthand mfc syntax
sbryngelson 3e4ba96
Merge upstream/master into homebrew-formula
sbryngelson a6d2641
Address PR #1038 feedback: standardize Homebrew command syntax
sbryngelson 5fecd1b
Simplify Homebrew wrapper: remove redundant 'mfc run' syntax
sbryngelson 76ac76e
Add error handling for 'mfc run' syntax
sbryngelson 41706e1
Improve wrapper validation and error messages
sbryngelson 58ba949
Fix RuboCop style error: remove redundant escape in regex
sbryngelson f125de6
Update packaging/homebrew/mfc.rb
sbryngelson 4b5c016
Fix RuboCop error and improve validation logic
sbryngelson 1a1865f
Fix 'run' detection to check first non-flag argument
sbryngelson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.