Skip to content

Test claude 4#1249

Closed
sbryngelson wants to merge 13 commits into
MFlowCode:masterfrom
sbryngelson:test-claude-4
Closed

Test claude 4#1249
sbryngelson wants to merge 13 commits into
MFlowCode:masterfrom
sbryngelson:test-claude-4

Conversation

@sbryngelson

@sbryngelson sbryngelson commented Feb 22, 2026

Copy link
Copy Markdown
Member

User description

Description

Summarize your changes and the motivation behind them.

Fixes #(issue)

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other: describe

Testing

How did you test your changes?

Checklist

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

CodeAnt-AI Description

Include more Fortran files in linting and make Claude code review post full output as single PR comment

What Changed

  • The Fortran linter now runs on fewer excluded paths, so additional source and include files that were previously skipped (many test/misc/pre_process excludes) are now checked.
  • The Claude code-review workflow now posts the full review output as a single top-level PR comment titled "Claude Code Review".
  • The code-review action is constrained to allow the Bash tool only, and the repository includes a settings file reflecting that allowed tool.

Impact

✅ More Fortran files linted during CI
✅ Full code-review output visible on the PR
✅ Clearer, single-location Claude review comments

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Removed excluded paths from .fortlsrc configuration.
Updated prompt format for code review action and added option to show full output.
Added claude_args to specify allowed tools for the code review.
Updated Claude Code Review action parameters and removed deprecated settings.
Added new exclusion paths to .fortlsrc configuration.
Removed several excluded paths from .fortlsrc configuration.
Copilot AI review requested due to automatic review settings February 22, 2026 23:07
@codeant-ai

codeant-ai Bot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@sbryngelson has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Feb 22, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@codeant-ai

codeant-ai Bot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review

  • Parse error handling
    The config enables skip_parse_errors and debug_parser. While this avoids hard failures, it can mask real parse issues introduced by the expanded linting. Confirm the intended behavior (fail CI vs. report-only) and ensure important parse errors are not silently ignored.

  • Disabled parser vs excludes
    Many previously-excluded files were removed from excl_paths and instead a long list is present under disable_parser. Review whether files should be fully excluded (via excl_paths) or selectively disabled for parsing. Using disable_parser for many files can make the config harder to maintain and unexpected files may still be discovered by the linter.

  • CI performance
    Narrowing the excluded paths causes many more Fortran files to be linted. This can significantly increase CI runtime and flakiness (timeouts) — verify CI job duration and consider limiting which directories are newly linted or running the expanded linting on a scheduled job instead of every PR.

@codeant-ai

codeant-ai Bot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

CodeAnt AI finished reviewing your PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository configuration for automated Claude-based code review and Fortran Language Server (fortls) indexing.

Changes:

  • Adjusts the Claude Code Review GitHub Action to show full output, pass --allowedTools "Bash(*)", and use a multi-line prompt.
  • Simplifies .fortlsrc excluded paths list.
  • Adds .claude/settings.json to configure allowed tools.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/claude-code-review.yml Expands Claude review job configuration (output verbosity, tool permissions, prompt formatting).
.fortlsrc Reduces excluded paths for fortls scanning.
.claude/settings.json Adds Claude settings to allow Bash(*).

Comment on lines +36 to +38
claude_args: |
--allowedTools "Bash(*)"

Copilot AI Feb 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pull_request_target while enabling Claude's Bash(*) tool and passing CLAUDE_CODE_OAUTH_TOKEN creates a high-risk privilege escalation path: the workflow has access to secrets on pull_request_target, and Bash can execute arbitrary commands against the checked-out fork HEAD. Consider removing Bash tool access, switching to pull_request (no secrets), or gating secret usage so it never runs for forked PRs (e.g., only for trusted actors/branches).

Suggested change
claude_args: |
--allowedTools "Bash(*)"

Copilot uses AI. Check for mistakes.
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
github_token: ${{ github.token }}

show_full_output: true

Copilot AI Feb 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show_full_output: true can leak sensitive information into workflow logs (including anything the review tool prints while it has access to tokens/secrets). If you keep this enabled, ensure secrets are never available in this job for untrusted PRs (especially with pull_request_target) or keep full output disabled.

Suggested change
show_full_output: true
show_full_output: false

Copilot uses AI. Check for mistakes.
@github-actions

Copy link
Copy Markdown

Claude Code Review

No issues found. Checked for bugs and CLAUDE.md compliance.

@sbryngelson sbryngelson deleted the test-claude-4 branch February 23, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Development

Successfully merging this pull request may close these issues.

2 participants