MPI_Abort fix #125
Merged
MPI_Abort fix #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small bug fixes another small bug
|
Can you confirm this to fix the main issue? |
|
@sbryngelson I intentionally introduced an error in an input file and ran it with 4 processes and the error was printed before s_mpi_abort was called. |
|
I agree this is probably the way to go on this issue. In the worst case, a few print statements will be issued and flushed to stdout, but is guaranteed that at least one of them will go through. It also doesn't introduce MPI barriers that could block the program from exiting if a call to abort is not made on all ranks. The caller is still free to have an MPI barrier prior to calling abort. |
sbryngelson
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #115