Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Directory, Formatting and Added Intent #476

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

okBrian
Copy link
Contributor

@okBrian okBrian commented Jun 20, 2024

Description

Formatting Changes and Added Intent to the Common Directory Only
Next is pre_process, sim, and post-process
Fixes #477

Type of change

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

  • Builds and Runs without Errors with Github Actions
  • Builds and Runs on local machine

Test Configuration:
Ubuntu 22.04.4 LTS, gcc 14

Checklist

  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

@sbryngelson sbryngelson merged commit 41d51b7 into MFlowCode:master Jun 20, 2024
19 checks passed
AiredaleDev pushed a commit to AiredaleDev/MFC that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Common
2 participants