From 8528af599022023ea653542c7a2710584ffd8ae0 Mon Sep 17 00:00:00 2001 From: XuzhengTian Date: Thu, 26 Jun 2025 14:14:51 -0400 Subject: [PATCH 1/4] Fix Skipped Test Issue --- toolchain/mfc/test/test.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/toolchain/mfc/test/test.py b/toolchain/mfc/test/test.py index 65cd2803d2..d54e045791 100644 --- a/toolchain/mfc/test/test.py +++ b/toolchain/mfc/test/test.py @@ -37,6 +37,7 @@ def __filter(cases_) -> typing.List[TestCase]: # Do not "continue" because "--to" might be the same as "--from" if bFoundFrom and case.get_uuid() == ARG("to"): cases = cases[from_i:i+1] + skipped_cases += [case for case in cases_ if case not in cases] bFoundTo = True break @@ -51,6 +52,7 @@ def __filter(cases_) -> typing.List[TestCase]: checkCase.append(case.get_uuid()) if not set(ARG("only")).issubset(set(checkCase)): cases.remove(case) + skipped_cases.append(case) for case in cases[:]: if case.ppn > 1 and not ARG("mpi"): @@ -63,9 +65,11 @@ def __filter(cases_) -> typing.List[TestCase]: ,'Axisymmetric', 'Transducer', 'Transducer Array', 'Cylindrical', 'HLLD', 'Example'] if any(label in case.trace for label in skip): cases.remove(case) + skipped_cases.append(case) if ARG("no_examples"): + skipped_cases += [case for case in cases if "Example" in case.trace] cases = [case for case in cases if not "Example" in case.trace] if ARG("percent") == 100: @@ -74,7 +78,7 @@ def __filter(cases_) -> typing.List[TestCase]: seed(time.time()) selected_cases = sample(cases, k=int(len(cases)*ARG("percent")/100.0)) - skipped_cases = [item for item in cases if item not in selected_cases] + skipped_cases += [item for item in cases if item not in selected_cases] return selected_cases, skipped_cases From e1a6605b35dc3b744b66cbf6c74c53ceb52c7163 Mon Sep 17 00:00:00 2001 From: XuzhengTian Date: Thu, 26 Jun 2025 14:30:37 -0400 Subject: [PATCH 2/4] Modify for Reviewer --- toolchain/mfc/test/test.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/toolchain/mfc/test/test.py b/toolchain/mfc/test/test.py index d54e045791..28c3cfb538 100644 --- a/toolchain/mfc/test/test.py +++ b/toolchain/mfc/test/test.py @@ -37,7 +37,7 @@ def __filter(cases_) -> typing.List[TestCase]: # Do not "continue" because "--to" might be the same as "--from" if bFoundFrom and case.get_uuid() == ARG("to"): cases = cases[from_i:i+1] - skipped_cases += [case for case in cases_ if case not in cases] + skipped_cases = [case for case in cases_ if case not in cases] bFoundTo = True break @@ -69,8 +69,9 @@ def __filter(cases_) -> typing.List[TestCase]: if ARG("no_examples"): - skipped_cases += [case for case in cases if "Example" in case.trace] - cases = [case for case in cases if not "Example" in case.trace] + example_cases = [case for case in cases if "Example" in case.trace] + skipped_cases += example_cases + cases = [case for case in cases if case not in example_cases] if ARG("percent") == 100: return cases, skipped_cases From 9ce824ea1bdc4fc3d320ae0add9aa255c07817d8 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Fri, 27 Jun 2025 13:21:50 -0400 Subject: [PATCH 3/4] mpi single --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f066f77f48..0c99e287c9 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,7 +35,7 @@ jobs: include: - os: ubuntu - mpi: no-mpi + mpi: mpi precision: single debug: no-debug intel: false From 889f1594a209df616fb2b932ae2aaaec8dbfd891 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Fri, 27 Jun 2025 19:41:42 -0400 Subject: [PATCH 4/4] Discard changes to .github/workflows/test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0c99e287c9..f066f77f48 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,7 +35,7 @@ jobs: include: - os: ubuntu - mpi: mpi + mpi: no-mpi precision: single debug: no-debug intel: false