Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bun package manager #274

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Add bun package manager #274

merged 4 commits into from
Nov 25, 2023

Conversation

ludicast
Copy link
Contributor

Bun is definitely growing and dependency-cruiser works fine with it locally. This adds it to your list of acceptable package managers - please let me know if I'm forgetting anything.

@ludicast ludicast requested a review from MH4GF as a code owner November 22, 2023 11:56
@@ -72,9 +72,9 @@ with:
cruise-script: yarn run -s depcruise --exclude "^lib"
```

### Usage with `npm` or `pnpm`
### Usage with `bun`, `npm` or `pnpm`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was adding alphabetically, bun can be wherever you want obviously.

@@ -38,7 +38,7 @@ jobs:
- uses: MH4GF/dependency-cruiser-report-action@v2
```

## Adbanced Usage
## Advanced Usage
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, thanks!

@MH4GF
Copy link
Owner

MH4GF commented Nov 23, 2023

@ludicast
CI is down, but it seems to be a problem that also occurs in the main branch. Please take this one in.

@ludicast
Copy link
Contributor Author

@ludicast CI is down, but it seems to be a problem that also occurs in the main branch. Please take this one in.

cool - caught up to main 🤞

@ludicast ludicast requested a review from MH4GF November 25, 2023 13:21
@MH4GF
Copy link
Owner

MH4GF commented Nov 25, 2023

https://github.com/MH4GF/dependency-cruiser-report-action/actions/runs/6989311066/job/19018112442

CI continues to fail... but this is a problem that pull requests from forked repositories must be on: pull_request_target to work.
There is a security concern, but this repository is not frequently maintained, so it will not be changed this time.

Copy link
Owner

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 😄

@MH4GF MH4GF merged commit 4645a88 into MH4GF:main Nov 25, 2023
5 of 6 checks passed
@MH4GF MH4GF mentioned this pull request Nov 25, 2023
@MH4GF
Copy link
Owner

MH4GF commented Nov 25, 2023

It works 👍🏻

@MH4GF MH4GF added the enhancement New feature or request label Nov 25, 2023
@MH4GF
Copy link
Owner

MH4GF commented Nov 25, 2023

🚀 v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants