[GCM] Fix auth tag generation for large data #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tream as DoTestEncodeStream_TestSingleSet. Move data set related knowledge into DoTestEncodeStream_LoadAndTestCAVSData, which will then test each set using DoTestEncodeStream_TestSingleSet. DoTestEncodeStream_TestSingleSet now allows to optionally use data chunking instead of processing whole stream at once. Also addressed issue where failed test would mislabeled printed data in error message.
…unked approach is functional and produces same result as whole stream approach. Test is currently failing due to a bug in GCM encryption logic, which results in incorrect tag generated for whole stream approach when stream size is larger then StreamBufferSize.
…hertext's size in CalcGaloisHash.
Contributor
Author
|
This PR should apply cleanly to development branch, but please let me know if you want a PR based on dev branch. Just a note that contribution guidelines are different between default branch and development branch, and thus new ones are not easily discoverable without some hints. |
Owner
|
Applied pull request #51 |
MHumm
added a commit
that referenced
this pull request
Dec 29, 2022
Fixed auth tag generation for large data as proposed by pull request #51
Owner
|
Fixed now. Next time please provide pull requests for development branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in GCM code that results in incorrect auth tag being generated whenever processing TBytes array with length longer from actual data size. Discoverable when trying to encode large stream in 'chunked' mode, but decrypting as a whole stream or vice versa.