Skip to content

Share ownership of Simulator and FuncMemory instances #662

Closed
pavelkryukov opened this issue Oct 19, 2018 · 1 comment
Closed

Share ownership of Simulator and FuncMemory instances #662

pavelkryukov opened this issue Oct 19, 2018 · 1 comment
Assignees
Labels
3 Features of medium complexity or infrastructure enhancements code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. S1 — C++ To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding.

Comments

@pavelkryukov
Copy link
Member

pavelkryukov commented Oct 19, 2018

Currently we have strict ownership for Simulator and FuncMemory instances. That's not the best solution, as we have to use strongly defined order of memory allocation and deallocation (destruct simulator, then memory). If our factories return std::shared_ptr instead of std::unique_ptr, we would have better memory management.

TBD — circular dependencies???

@pavelkryukov pavelkryukov added 1 Usually one-liner tasks, but may require some deep into infrastructure. good first issue Good task to start with MIPT-MIPS development S1 — C++ To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding. code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. labels Oct 19, 2018
@pavelkryukov pavelkryukov changed the title Use shared ownership for Simulator and FuncMemory classes Share ownership of Simulator and FuncMemory instances Oct 20, 2018
@pavelkryukov pavelkryukov added 3 Features of medium complexity or infrastructure enhancements and removed 1 Usually one-liner tasks, but may require some deep into infrastructure. good first issue Good task to start with MIPT-MIPS development labels Oct 21, 2018
@trexxet trexxet self-assigned this Oct 24, 2018
@trexxet
Copy link
Contributor

trexxet commented Oct 24, 2018

Looks like I have to implement this to implement Kernel class (#665).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 Features of medium complexity or infrastructure enhancements code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. S1 — C++ To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding.
Projects
None yet
Development

No branches or pull requests

2 participants