You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pavelkryukov opened this issue
Oct 19, 2018
· 1 comment
Assignees
Labels
3Features of medium complexity or infrastructure enhancementscodeEnhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture.S1 — C++To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding.
Currently we have strict ownership for Simulator and FuncMemory instances. That's not the best solution, as we have to use strongly defined order of memory allocation and deallocation (destruct simulator, then memory). If our factories return std::shared_ptr instead of std::unique_ptr, we would have better memory management.
TBD — circular dependencies???
The text was updated successfully, but these errors were encountered:
pavelkryukov
added
1
Usually one-liner tasks, but may require some deep into infrastructure.
good first issue
Good task to start with MIPT-MIPS development
S1 — C++
To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding.
code
Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture.
labels
Oct 19, 2018
pavelkryukov
changed the title
Use shared ownership for Simulator and FuncMemory classes
Share ownership of Simulator and FuncMemory instances
Oct 20, 2018
pavelkryukov
added
3
Features of medium complexity or infrastructure enhancements
and removed
1
Usually one-liner tasks, but may require some deep into infrastructure.
good first issue
Good task to start with MIPT-MIPS development
labels
Oct 21, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3Features of medium complexity or infrastructure enhancementscodeEnhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture.S1 — C++To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding.
Currently we have strict ownership for Simulator and FuncMemory instances. That's not the best solution, as we have to use strongly defined order of memory allocation and deallocation (destruct simulator, then memory). If our factories return
std::shared_ptr
instead ofstd::unique_ptr
, we would have better memory management.TBD — circular dependencies???
The text was updated successfully, but these errors were encountered: