Add Postgres version requirement to README

[tnaumann]

The addition of queries that use percentile_cont move the minimum Postgres version to 9.4. Adding this to the README would result in less confusion during.

[alistairewj]

Materialized views require 9.4 too.. it might be worth adding a unit test
in the build for the version.

On Oct 7, 2016 12:34 PM, "tnaumann" notifications@github.com wrote:

The addition of queries that use percentile_cont move the minimum
Postgres version to 9.4. Adding this to the README would result in less
confusion during.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#138, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOSdNq2IFnbmlLWVTsIVCzJyBd6SvKrks5qxnSBgaJpZM4KROaV
.

[tnaumann]

I think materialized view exists in Postgres 9.3 (https://www.postgresql.org/docs/9.3/static/sql-creatematerializedview.html).

A unit test would be even better. Overall idea is to give the user warning that the build is failing because of an insufficient Postgres version rather than discovering this from a slew syntax errors.

[tnaumann]

Have you tested on 9.5+? If so, we can use something like:

ifndef MAJORVERSION
    MAJORVERSION := $(basename $(VERSION))
endif

PG94_OR_LATER := $(shell expr $(value MAJORVERSION) \>= 9.4)
ifeq ($(PG94_OR_LATER), 0)
    $(error PostgreSQL 9.4 or later is required to build MIMIC)
endif

Otherwise, if it has to be exactly 9.4, we can use something like:

ifndef MAJORVERSION
    MAJORVERSION := $(basename $(VERSION))
endif

ifeq (,$(findstring $(MAJORVERSION), 9.4))
    $(error PostgreSQL 9.4 is required to build MIMIC)
endif

[alistairewj]

Yeah I use 9.5 and everything works smoothly. We can probably require>=9.4
and be fine... I think Nicolas ( @parisni ) may have even built it on 9.6.

On Fri, Oct 7, 2016 at 12:53 PM, tnaumann notifications@github.com wrote:

Have you tested on 9.5+? If so, we can use something like:

ifndef MAJORVERSION
MAJORVERSION := $(basename $(VERSION))
endif

PG94_OR_LATER := $(shell expr $(value MAJORVERSION) >= 9.4)
ifeq ($(PG94_OR_LATER), 0)
$(error PostgreSQL 9.4 or later is required to build MIMIC)
endif

Otherwise, if it has to be exactly 9.4, we can use something like:

ifndef MAJORVERSION
MAJORVERSION := $(basename $(VERSION))
endif

ifeq (,$(findstring $(MAJORVERSION), 9.4))
$(error PostgreSQL 9.4 is required to build MIMIC)
endif

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#138 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOSdHJiaPQyMbXj1Gxix1tm36jKcFqBks5qxnj0gaJpZM4KROaV
.