Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Port and build path in Docker instructions #148

Closed
florinb opened this Issue Nov 11, 2016 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

florinb commented Nov 11, 2016

In both Step 1 and 2 the cd /mimic_code/buildmimic/postgres is used when instead it should be, imho, cd /mimic_code/buildmimic/docker.

Also, shouldn't the second example from Step 3 use port 5432 instead 5455? I assume the example is based on a custom configuration that doesn't match the current db config.

@tompollard tompollard changed the title from typo on docker/Readme.md to Port and build path in Docker instructions Nov 11, 2016

@alistairewj alistairewj added a commit that referenced this issue Apr 14, 2017

@alistairewj alistairewj Merge pull request #149 from florinb/master
changes for port and build path in Docker instructions #148
0060613
Owner

alistairewj commented Apr 14, 2017

Little slow but I fixed it. My memory is hazy but I'm pretty sure the docker port has to be 5432, but the host port is whatever you decide (e.g. in that config it was 5455). So the 5455:5455 is wrong, but 5455:5432 would be correct. I'm sure 5432:5432 would work as well, but might prevent you from connecting to any local postgres databases you might have so I wouldn't recommend it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment