Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Port and build path in Docker instructions #148
Comments
|
This issue refers to: https://github.com/MIT-LCP/mimic-code/tree/master/buildmimic/docker |
tompollard
changed the title from
typo on docker/Readme.md to Port and build path in Docker instructions
Nov 11, 2016
alistairewj
added a commit
that referenced
this issue
Apr 14, 2017
|
|
alistairewj |
0060613
|
|
Little slow but I fixed it. My memory is hazy but I'm pretty sure the docker port has to be 5432, but the host port is whatever you decide (e.g. in that config it was 5455). So the 5455:5455 is wrong, but 5455:5432 would be correct. I'm sure 5432:5432 would work as well, but might prevent you from connecting to any local postgres databases you might have so I wouldn't recommend it. |
florinb commentedNov 11, 2016
In both Step 1 and 2 the
cd /mimic_code/buildmimic/postgresis used when instead it should be, imho,cd /mimic_code/buildmimic/docker.Also, shouldn't the second example from Step 3 use port 5432 instead 5455? I assume the example is based on a custom configuration that doesn't match the current db config.