Skip to content

Conversation

@briangow
Copy link
Contributor

symbol needs to be defined in calc_core_bytes so the annotations can be converted into bytes for writing. I added this to define symbol when label_store is being used:

 # Calculate the symbol field if necessary
        if 'symbol' not in present_label_fields:
            self.convert_label_attribute(source_field=present_label_fields[0],
                                         target_field='symbol')

@briangow briangow requested a review from Lucas-Mc February 23, 2021 15:10
@briangow briangow linked an issue Feb 23, 2021 that may be closed by this pull request
Copy link
Contributor

@Lucas-Mc Lucas-Mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax looks good and consistent and it works!

@Lucas-Mc Lucas-Mc merged commit 6582b17 into master Feb 23, 2021
@Lucas-Mc Lucas-Mc deleted the wrann branch February 23, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrann not working with only label_store set in Annotation

3 participants