Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kimera-vio-ros gtsam build fails on Ubuntu 20.04 #115

Open
berndpfrommer opened this issue Nov 5, 2020 · 1 comment
Open

kimera-vio-ros gtsam build fails on Ubuntu 20.04 #115

berndpfrommer opened this issue Nov 5, 2020 · 1 comment

Comments

@berndpfrommer
Copy link

I've added support for Ubuntu 20.04 to Kimera and wanted to submit a PR, but hit a snag regarding GTSAM.

Kimera-vio-ros currently does not build for two reasons:

  1. The image_undistort node does not compile with the c++-11 flag. I have filed a PR against the repo: compile under Ubuntu 20.04 ethz-asl/image_undistort#64 so hopefully this will be fixed at some point.

  2. The "master" branch of gtsam does not compile because it has a broken CMakeLists.txt file in the "wrap" subdirectory (some matlab wrappers):

CMake Error at /home/pfrommer/Documents/kimera/src/gtsam/wrap/CMakeLists.txt:32 (target_link_libraries):
  The "debug" argument must be followed by a library.

This has been fixed with the latest gtsam release 4.0.3. Alas, gtsam v4.0.3 does not build on ubuntu 14.04 (trusty), because for that very same fix it requires cmake > 3.0.0, whereas trusty has only 2.8.12. In a pinch people can install cmake 3 on Ubuntu 14.04, so there is a workaround: https://askubuntu.com/questions/610291/how-to-install-cmake-3-2-on-ubuntu

Question: how important is it for you to keep support for Ubuntu 14.04?

@ToniRV
Copy link
Collaborator

ToniRV commented Nov 5, 2020

Hi @berndpfrommer,

We only test for >=16.04, so 14.04 is not officially supported.

Thanks for the detailed issue!
We could add a build to our CI server with 20.04 and git checkout 4.0.3 in gtsam.
We could then just update the install readme.

Note though that I have no CI with the ROS wrapper:

Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants