Di59 result error handling #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables rollbar and enables more logging
What: * This presents an error message to users when things go awry during the XHR requests * This does not try to get fancy and report errors from the client side, but instead assumes the errors would have been logged during the rails server side processing (which is probably true) * It does log to the end user's JavaScript console the xhr response when this is triggered so in theory we could work with tech savvy users to get a copy of the request if necessary (probably not) * This also adds a timeout of 6 seconds to the EDS API calls and logs all URLs to EDS for debug purposes Why: * The previous fail state was an infinitely spinning loader image which was obviously not too helpful Note: * see also https://mitlibraries.atlassian.net/browse/DI-59
Member
Author
|
@matt-bernhardt I flagged you for review as this affects the GA logging you did. I think I didn't break it, but I also didn't check ;) |
Contributor
|
UX lgtm 👍 |
matt-bernhardt
approved these changes
Jan 24, 2017
Member
matt-bernhardt
left a comment
matt-bernhardt
left a comment
There was a problem hiding this comment.
The deployed branch still records clicked results for the panels that do work, so this doesn't break what's already there.
Seeing this behavior does point out that we're missing a few non-result links that may need to be recorded - but that's outside the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
XHR requests
but instead assumes the errors would have been logged during the rails
server side processing (which is probably true)
this is triggered so in theory we could work with tech savvy users to
get a copy of the request if necessary (probably not)
all URLs to EDS for debug purposes
Why:
was obviously not too helpful
Note: