Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Apr 3, 2024

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

@mitlib mitlib temporarily deployed to mit-bento-pr-1293 April 3, 2024 18:50 Inactive
@jazairi jazairi merged commit ace49a4 into main Apr 3, 2024
@jazairi jazairi deleted the update-dependencies branch April 3, 2024 18:54
@coveralls
Copy link

Coverage Status

coverage: 99.216%. remained the same
when pulling 1a60beb on update-dependencies
into 70e5c9f on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants