metadata json transform #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakbailey
approved these changes
Feb 24, 2020
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
Ok to merge. See non-blocking comments inline for suggestions on code improvements.
Contributor
Author
|
Refactored in response to @hakbailey's comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding a command with 2 new functions (and corresponding tests) to transform a CSV into JSON metadata that will be used to upload collections into DSpace. In
cli.py, lines 157-185 are specific to this particular collection. If this code does end up getting used for other collections, I'll want to discuss how to efficiently manage this crosswalk code since it will vary for each collectionIncludes new or updated dependencies?
NO