From 6255aa4de08bb26052e84e2dab30aadb8dbd5462 Mon Sep 17 00:00:00 2001 From: Helen Bailey Date: Thu, 23 Sep 2021 10:06:11 -0400 Subject: [PATCH] Minor changes based on PR feedback --- setup.py | 2 +- submitter/sqs.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/setup.py b/setup.py index b8146a5..1c49758 100644 --- a/setup.py +++ b/setup.py @@ -11,7 +11,7 @@ "smart-open", ( "dspace-python-client @ git+https://github.com/mitlibraries/" - "dspace-python-client@0.1.0#egg=dspace" + "dspace-python-client@0.1.0#egg=dspace-python-client" ), ], entry_points={"console_scripts": ["submitter=submitter.cli:main"]}, diff --git a/submitter/sqs.py b/submitter/sqs.py index b2ea842..c0aa350 100644 --- a/submitter/sqs.py +++ b/submitter/sqs.py @@ -12,7 +12,7 @@ def message_loop(queue, wait): logger.info("Message loop started") - msgs = retrieve(queue, wait) + msgs = retrieve_messages_from_queue(queue, wait) if len(msgs) > 0: process(msgs) @@ -35,7 +35,7 @@ def process(msgs): # TODO: handle and test submit message errors raise e submission.submit(client) - write( + write_message_to_queue( submission.result_attributes, json.dumps(submission.result_message), submission.result_queue, @@ -46,7 +46,7 @@ def process(msgs): logger.info("Deleted message %s from input queue", message_id) -def retrieve(input_queue, wait): +def retrieve_messages_from_queue(input_queue, wait): sqs = boto3.resource("sqs") queue = sqs.get_queue_by_name(QueueName=input_queue) @@ -62,7 +62,7 @@ def retrieve(input_queue, wait): return msgs -def write(attributes, body, output_queue): +def write_message_to_queue(attributes, body, output_queue): sqs = boto3.resource("sqs") queue = sqs.get_queue_by_name(QueueName=output_queue) queue.send_message(