Skip to content

Update initial app name #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 18, 2022
Merged

Update initial app name #3

merged 4 commits into from
Aug 18, 2022

Conversation

@hakbailey
Copy link
Contributor

@hakbailey hakbailey commented Aug 5, 2022 •
edited
Loading

What does this PR do?

Updates the template app name and adds some configuration updates.

Includes new or updated dependencies?

YES

Developer

  • All new ENV is documented in README (or there is none)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

hakbailey added 4 commits July 19, 2022 15:51
@hakbailey
Update initial app name across the repo
ba85f85 
Why these changes are being introduced:
"app" was too generic a term to use as the initial app name. It meant a
find-and-replace across the repo would change many more things than the
actual app name (for example, documentation including the words "app" or
"application"). A better initial name is one that is not part of other
words and would *only* be used in places where the app name matters in
the code, making it easy to find and replace.

How this addresses that need:
* Replaces the app name "app" with "my_app" across the repo to ensure
  future users of this template can easily update the app name when
  first creating it.
@hakbailey
Add pydocstyle config
c945123
@hakbailey
Add isort configuration
9d3f7e5
@hakbailey
Pin pyflakes version until pylama fixes bug with 2.5.0
a791611
@hakbailey hakbailey requested a review from ehanson8 August 5, 2022 20:35
@hakbailey hakbailey merged commit 103a249 into main Aug 18, 2022
@hakbailey hakbailey deleted the update-initial-app-name branch August 18, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehanson8 ehanson8 ehanson8 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hakbailey @ehanson8